From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH/RFC manager 2/2] ui: qemu: CD edit: make label for storage more descriptive
Date: Mon, 19 Sep 2022 11:16:21 +0200 [thread overview]
Message-ID: <20220919091621.29538-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20220919091621.29538-1-f.ebner@proxmox.com>
Namely, use "ISO storage" instead of "Storage". Relevant when inside
the wizard, to avoid any confusion, but doesn't really feel wrong in
the normal edit window either.
Suggested in the community forum:
https://forum.proxmox.com/threads/75219/post-498758
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
I feel like the first patch might already be enough, but this would
drive home the point.
www/manager6/qemu/CDEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
index f409fa53..33c12d43 100644
--- a/www/manager6/qemu/CDEdit.js
+++ b/www/manager6/qemu/CDEdit.js
@@ -118,7 +118,7 @@ Ext.define('PVE.qemu.CDInputPanel', {
me.cdstoragesel = Ext.create('PVE.form.StorageSelector', {
name: 'cdstorage',
nodename: me.nodename,
- fieldLabel: gettext('Storage'),
+ fieldLabel: gettext('ISO storage'),
labelAlign: 'right',
storageContent: 'iso',
allowBlank: false,
--
2.30.2
next prev parent reply other threads:[~2022-09-19 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 9:16 [pve-devel] [PATCH manager 1/2] ui: qemu: CD edit: add "Installation media" label when in wizard Fiona Ebner
2022-09-19 9:16 ` Fiona Ebner [this message]
2022-09-19 10:01 ` [pve-devel] [PATCH/RFC manager 2/2] ui: qemu: CD edit: make label for storage more descriptive Thomas Lamprecht
2022-09-19 11:00 ` [pve-devel] [PATCH manager 1/2] ui: qemu: CD edit: add "Installation media" label when in wizard Thomas Lamprecht
2022-09-22 8:18 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919091621.29538-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox