public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/2] ui: qemu: CD edit: add "Installation media" label when in wizard
Date: Mon, 19 Sep 2022 11:16:20 +0200	[thread overview]
Message-ID: <20220919091621.29538-1-f.ebner@proxmox.com> (raw)

People sometimes expect to select the storage for the VM's disk first.
This should make the context clearer.

Suggested in the community forum:
https://forum.proxmox.com/threads/75219/post-498758

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 www/manager6/qemu/CDEdit.js | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
index fc7a59cc..f409fa53 100644
--- a/www/manager6/qemu/CDEdit.js
+++ b/www/manager6/qemu/CDEdit.js
@@ -76,6 +76,13 @@ Ext.define('PVE.qemu.CDInputPanel', {
 	    items.push(me.bussel);
 	}
 
+	if (me.insideWizard) {
+	    items.push({
+		xtype: 'displayfield',
+		value: `${gettext('Installation media')}:`,
+	    });
+	}
+
 	items.push({
 	    xtype: 'radiofield',
 	    name: 'mediaType',
-- 
2.30.2





             reply	other threads:[~2022-09-19  9:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19  9:16 Fiona Ebner [this message]
2022-09-19  9:16 ` [pve-devel] [PATCH/RFC manager 2/2] ui: qemu: CD edit: make label for storage more descriptive Fiona Ebner
2022-09-19 10:01   ` Thomas Lamprecht
2022-09-19 11:00 ` [pve-devel] [PATCH manager 1/2] ui: qemu: CD edit: add "Installation media" label when in wizard Thomas Lamprecht
2022-09-22  8:18   ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220919091621.29538-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal