public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager/qemu-server/pve-container v2] Add checkbox for automatic restart of CT/VM after rollback
Date: Mon, 12 Sep 2022 14:00:05 +0200	[thread overview]
Message-ID: <20220912120008.1220711-1-s.hanreich@proxmox.com> (raw)

Update to my first patch, that added a warning to the rollback dialog. As
discussed in Bugzilla, I added a checkbox to toggle an automatic restart to the
rollback window instead of displaying a warning. The restart functionality
itself is implemented in the respective backends.

One difference to the existing dialog window is, that the new one doesn't use
MessageBox anymore as its base component. This is because, it is quite tricky
to add custom elements to the MessageBox and get their values. This leads to
the dialog looking slightly different, since there is no question mark icon
anymore.

pve-manager:

Stefan Hanreich (1):
  fix #4228: ui: Add checkbox to rollback dialog for automatically
    restarting VM/CT

 www/manager6/tree/SnapshotTree.js | 62 +++++++++++++++++++++++++++----
 1 file changed, 55 insertions(+), 7 deletions(-)


qemu-server:

Stefan Hanreich (1):
  fix #4228: add start parameter to rollback endpoint for automatic
    restarting of VM

 PVE/API2/Qemu.pm | 12 ++++++++++++
 1 file changed, 12 insertions(+)


pve-container:

Stefan Hanreich (1):
  fix #4228: add start parameter to rollback endpoint for automatic
    restarting of CT

 src/PVE/API2/LXC/Snapshot.pm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

-- 
2.30.2




             reply	other threads:[~2022-09-12 12:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-12 12:00 Stefan Hanreich [this message]
2022-09-12 12:00 ` [pve-devel] [PATCH pve-container v2 1/1] fix #4228: add start parameter to rollback endpoint for automatic restarting of CT Stefan Hanreich
2022-09-12 14:12   ` Thomas Lamprecht
2022-09-12 12:00 ` [pve-devel] [PATCH qemu-server v2 1/1] fix #4228: add start parameter to rollback endpoint for automatic restarting of VM Stefan Hanreich
2022-09-12 14:15   ` Thomas Lamprecht
2022-09-12 12:00 ` [pve-devel] [PATCH manager v2 1/1] fix #4228: ui: Add checkbox to rollback dialog for automatically restarting VM/CT Stefan Hanreich
2022-09-12 14:36   ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220912120008.1220711-1-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal