public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-login-manager/pve-flutter-frontend] fixes & update to flutter 3.3
Date: Thu,  8 Sep 2022 11:55:37 +0200	[thread overview]
Message-ID: <20220908095550.2913416-1-d.csapak@proxmox.com> (raw)

updates to the code for flutter 3.3 and includes some fixes & improvements

i included aarons patches from december to make it easier to apply

the changes necesseary for flutter 3.3 are
proxmox-login-manager: 2/3
pve-flutter-frontend: 2/10 - 6/10

patches after that are only fixes & improvements
(so stricly not necessary for flutter 3.3)

i noticed some other things too, but for now this should be ok:
e.g. we have quite some widgets/code that are not in use currently
(from tims desktop variant AFAIR), maybe we should remove them
for now (or move it to another repo if we want to use them)
since then we could better use 'flutter analyze'
(now these widgets/files make much noise to the point where it's hard
to see which warnings/infos are even relevant for the app)

proxmox-login-manager:

Aaron Lauterer (1):
  login_form: keep Continue button above Android softnav

Dominik Csapak (2):
  migrate from FlatButton to TextButton
  improve colors of login screen

 lib/proxmox_login_form.dart | 288 +++++++++++++++++++-----------------
 lib/proxmox_tfa_form.dart   |  11 +-
 2 files changed, 156 insertions(+), 143 deletions(-)

pve-flutter-frontend:

Aaron Lauterer (1):
  avoid elements hiding behind Android softnav buttons

Dominik Csapak (9):
  increase compileSdkVersion to 32
  fix null handling in MainActivity.kt
  move to OutlinedButton from OutlineButton
  move to TextButton from FlatButton
  move to ElevatedButton from RaisedButton
  improve colors for indicator/toggles
  fix typo Opague -> Opaque
  fix guest backup widget start display
  fix options view when ostype is null

 android/app/build.gradle                      |   2 +-
 .../app/pve_flutter_frontend/MainActivity.kt  |   2 +-
 lib/main.dart                                 |  14 +
 lib/pages/main_layout_slim.dart               |   2 +-
 .../firstWelcomeScreen/pve_welcome_faq.dart   |  10 +-
 .../firstWelcomeScreen/pve_welcome_last.dart  |  26 +-
 lib/widgets/pve_cd_selector_widget.dart       |   7 +-
 lib/widgets/pve_console_menu_widget.dart      |   4 +-
 lib/widgets/pve_first_welcome_screen.dart     |  32 +-
 lib/widgets/pve_guest_backup_widget.dart      | 157 ++++-----
 lib/widgets/pve_lxc_options_widget.dart       | 140 ++++----
 lib/widgets/pve_main_navigation_drawer.dart   |   4 +-
 lib/widgets/pve_qemu_options_widget.dart      | 259 +++++++-------
 lib/widgets/pve_qemu_overview.dart            | 319 +++++++++---------
 .../pve_qemu_power_settings_widget.dart       | 178 +++++-----
 .../pve_subscription_alert_dialog.dart        |   2 +-
 .../pve_task_log_expansiontile_widget.dart    |   4 +-
 17 files changed, 602 insertions(+), 560 deletions(-)

-- 
2.30.2





             reply	other threads:[~2022-09-08  9:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08  9:55 Dominik Csapak [this message]
2022-09-08  9:55 ` [pve-devel] [PATCH proxmox-login-manager 1/3] login_form: keep Continue button above Android softnav Dominik Csapak
2022-09-08  9:55 ` [pve-devel] [PATCH proxmox-login-manager 2/3] migrate from FlatButton to TextButton Dominik Csapak
2022-09-08  9:55 ` [pve-devel] [PATCH proxmox-login-manager 3/3] improve colors of login screen Dominik Csapak
2022-09-08  9:55 ` [pve-devel] [PATCH pve-flutter-frontend 01/10] avoid elements hiding behind Android softnav buttons Dominik Csapak
2022-09-08  9:55 ` [pve-devel] [PATCH pve-flutter-frontend 02/10] increase compileSdkVersion to 32 Dominik Csapak
2022-09-08  9:55 ` [pve-devel] [PATCH pve-flutter-frontend 03/10] fix null handling in MainActivity.kt Dominik Csapak
2022-09-08  9:55 ` [pve-devel] [PATCH pve-flutter-frontend 04/10] move to OutlinedButton from OutlineButton Dominik Csapak
2022-09-08  9:55 ` [pve-devel] [PATCH pve-flutter-frontend 05/10] move to TextButton from FlatButton Dominik Csapak
2022-09-08  9:55 ` [pve-devel] [PATCH pve-flutter-frontend 06/10] move to ElevatedButton from RaisedButton Dominik Csapak
2022-09-08  9:55 ` [pve-devel] [PATCH pve-flutter-frontend 07/10] improve colors for indicator/toggles Dominik Csapak
2022-09-08  9:55 ` [pve-devel] [PATCH pve-flutter-frontend 08/10] fix typo Opague -> Opaque Dominik Csapak
2022-09-08  9:55 ` [pve-devel] [PATCH pve-flutter-frontend 09/10] fix guest backup widget start display Dominik Csapak
2022-09-08  9:55 ` [pve-devel] [PATCH pve-flutter-frontend 10/10] fix options view when ostype is null Dominik Csapak
2022-09-08 15:31 ` [pve-devel] applied-series: [PATCH proxmox-login-manager/pve-flutter-frontend] fixes & update to flutter 3.3 Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220908095550.2913416-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal