From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/2] ui: CephInstallWizard: make first mon node static
Date: Wed, 10 Aug 2022 17:10:19 +0200 [thread overview]
Message-ID: <20220810151020.573769-1-a.lauterer@proxmox.com> (raw)
Removes the possibility to select the node on which to create the first
monitor in the configuration / initialization step and always sets it to
the current node.
This prevents that a user might select another node on which the Ceph
packages have not yet been installed. If a user did that, they would get
an error, but the Ceph config file would have been written. If the user
then does not select a valid node to create the first mon, but aborts
the wizard, they are greeted with a rados_connect error because the
config file exists, but it does not contain any mon infos that are
needed to connect to the Ceph cluster.
Creating a mon manually will remedy such a situation, but especially for
new users, this behavior is not ideal and confusing.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
www/manager6/ceph/CephInstallWizard.js | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js
index 79b0f4e4..b19d1a5e 100644
--- a/www/manager6/ceph/CephInstallWizard.js
+++ b/www/manager6/ceph/CephInstallWizard.js
@@ -401,11 +401,11 @@ Ext.define('PVE.ceph.CephInstallWizard', {
value: gettext('First Ceph monitor') + ':',
},
{
- xtype: 'pveNodeSelector',
+ xtype: 'displayfield',
fieldLabel: gettext('Monitor node'),
- name: 'mon-node',
- selectCurNode: true,
- allowBlank: false,
+ cbind: {
+ value: '{nodename}',
+ },
},
{
xtype: 'displayfield',
@@ -461,8 +461,6 @@ Ext.define('PVE.ceph.CephInstallWizard', {
var wizard = me.up('window');
var kv = wizard.getValues();
delete kv.delete;
- var monNode = kv['mon-node'];
- delete kv['mon-node'];
var nodename = me.nodename;
delete kv.nodename;
Proxmox.Utils.API2Request({
@@ -472,7 +470,7 @@ Ext.define('PVE.ceph.CephInstallWizard', {
params: kv,
success: function() {
Proxmox.Utils.API2Request({
- url: `/nodes/${monNode}/ceph/mon/${monNode}`,
+ url: `/nodes/${nodename}/ceph/mon/${nodename}`,
waitMsgTarget: wizard,
method: 'POST',
success: function() {
--
2.30.2
next reply other threads:[~2022-08-10 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 15:10 Aaron Lauterer [this message]
2022-08-10 15:10 ` [pve-devel] [PATCH manager 2/2] ui: CephInstall: fix a/an typo Aaron Lauterer
2022-09-07 13:28 ` [pve-devel] applied: " Thomas Lamprecht
2022-09-07 13:26 ` [pve-devel] applied: [PATCH manager 1/2] ui: CephInstallWizard: make first mon node static Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220810151020.573769-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox