From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Oguz Bektas <o.bektas@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied: [PATCH container] fix #4164: use DHCP=yes instead of DHCP=both in systemd-networkd config
Date: Fri, 22 Jul 2022 14:50:58 +0200 [thread overview]
Message-ID: <20220722125058.vmdslo5zvisv5tcb@wobu-vie.proxmox.com> (raw)
In-Reply-To: <YtabimEy5PeG09tP@gaia>
On Tue, Jul 19, 2022 at 01:54:50PM +0200, Oguz Bektas wrote:
> On Tue, Jul 19, 2022 at 01:52:37PM +0200, Fabian Grünbichler wrote:
> > On July 19, 2022 1:24 pm, Oguz Bektas wrote:
> > > "both" option is deprecated, this gets rid of the warning in the journal
> > >
> > > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> >
> > some notion which templates you tested this with, when the deprecation
> > happened in systemd, whether we need a fallback to 'both' for older
> > versions, etc.pp. would be nice to have..
> >
> > AFAICT the deprecation was in systemd v219, so should probably be okay
> > to switch unconditionally..
>
> yes, all our current templates are using the newer systemd versions, so
> no need for a fallback IMO.
>
> i tested it with:
> * arch
> * fedora 35 and 36
> * ubuntu 20 and 22
> templates, it got rid of the warning in all of them.
Introduced in 2015 is old enough. Anybody using a container which
actually uses systemd-networkd *and* is that old will just have to
enable dhcp manually...
Applied.
next prev parent reply other threads:[~2022-07-22 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 11:24 [pve-devel] " Oguz Bektas
2022-07-19 11:52 ` Fabian Grünbichler
2022-07-19 11:54 ` Oguz Bektas
2022-07-22 12:50 ` Wolfgang Bumiller [this message]
2022-07-25 8:25 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722125058.vmdslo5zvisv5tcb@wobu-vie.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox