public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Matthias Heiserer <m.heiserer@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit] fix #4165: SMART: use changed columns from the API
Date: Thu, 21 Jul 2022 12:45:59 +0200	[thread overview]
Message-ID: <20220721104559.302270-3-m.heiserer@proxmox.com> (raw)
In-Reply-To: <20220721104559.302270-1-m.heiserer@proxmox.com>

Makes the column names and the data name in the API consistent.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 src/window/DiskSmart.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js
index 3c8040b..fc4b2cc 100644
--- a/src/window/DiskSmart.js
+++ b/src/window/DiskSmart.js
@@ -37,13 +37,13 @@ Ext.define('Proxmox.window.DiskSmart', {
 		    renderer: Ext.String.htmlEncode,
 		},
 		{
-		    text: gettext('Value'),
+		    text: gettext('Raw'),
 		    dataIndex: 'raw',
 		    renderer: Ext.String.htmlEncode,
 		},
 		{
 		    text: gettext('Normalized'),
-		    dataIndex: 'value',
+		    dataIndex: 'normalized',
 		    width: 60,
 		},
 		{
@@ -154,7 +154,7 @@ Ext.define('Proxmox.window.DiskSmart', {
     Ext.define('pmx-smart-attribute', {
 	extend: 'Ext.data.Model',
 	fields: [
-	    { name: 'id', type: 'number' }, 'name', 'value', 'worst', 'threshold', 'flags', 'fail', 'raw',
+	    { name: 'id', type: 'number' }, 'name', 'raw', 'worst', 'threshold', 'flags', 'fail', 'normalized',
 	],
 	idProperty: 'name',
     });
-- 
2.30.2





  parent reply	other threads:[~2022-07-21 10:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21 10:45 [pve-devel] [PATCH proxmox-backup] fix #4165: SMART: add raw field Matthias Heiserer
2022-07-21 10:45 ` [pve-devel] [PATCH pve-storage] fix #4165: disk: SMART: add normalized field Matthias Heiserer
2022-09-23 10:29   ` [pve-devel] applied: [pbs-devel] " Thomas Lamprecht
2022-07-21 10:45 ` Matthias Heiserer [this message]
2022-09-22 10:35 ` [pve-devel] [PATCH proxmox-backup] fix #4165: SMART: add raw field Dominik Csapak
2022-09-23 10:31   ` [pve-devel] [pbs-devel] " Thomas Lamprecht
2022-09-23 10:28 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220721104559.302270-3-m.heiserer@proxmox.com \
    --to=m.heiserer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal