From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-common 1/5] pbs client: delete password: return success for non-existent file
Date: Wed, 20 Jul 2022 12:59:41 +0200 [thread overview]
Message-ID: <20220720105948.291740-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20220720105948.291740-1-f.ebner@proxmox.com>
It's currently possible to add a remote in PMG without password (via
API), but deletion of such a remote would fail here.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
src/PVE/PBSClient.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm
index 37385d7..f19199c 100644
--- a/src/PVE/PBSClient.pm
+++ b/src/PVE/PBSClient.pm
@@ -77,7 +77,7 @@ sub delete_password {
my $pwfile = password_file_name($self);
- unlink $pwfile or die "deleting password file failed - $!\n";
+ unlink $pwfile or $! == ENOENT or die "deleting password file failed - $!\n";
};
sub get_password {
--
2.30.2
next prev parent reply other threads:[~2022-07-20 10:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 10:59 [pve-devel] [PATCH-SERIES pve-common/pmg-api/pve-storage] pbs client: rework namespace usage and minor fixes Fabian Ebner
2022-07-20 10:59 ` Fabian Ebner [this message]
2022-07-20 10:59 ` [pve-devel] [PATCH pve-common 2/5] pbs client: forget snapshot: suppress output Fabian Ebner
2022-07-20 10:59 ` [pve-devel] [PATCH pve-common 3/5] pbs client: default to configured namespace for non-namespaced parameters Fabian Ebner
2022-11-04 8:44 ` [pve-devel] [pmg-devel] " Fiona Ebner
2022-07-20 10:59 ` [pve-devel] [RFC/PATCH pve-common 4/5] pbs client: deprecate namespaced parameters Fabian Ebner
2022-07-20 10:59 ` [pve-devel] [RFC/PATCH pve-common 5/5] pbs client: backup fs tree: drop namespace parameter Fabian Ebner
2022-07-22 10:53 ` Wolfgang Bumiller
2022-07-25 8:04 ` Fiona Ebner
2022-11-04 13:16 ` [pve-devel] applied-series: " Wolfgang Bumiller
2022-07-20 10:59 ` [pve-devel] [PATCH pmg-api 1/2] api: get group snapshots: take backup-id into account Fabian Ebner
2022-11-04 13:28 ` [pve-devel] applied-series: " Wolfgang Bumiller
2022-07-20 10:59 ` [pve-devel] [RFC/PATCH pmg-api 2/2] api: pbs: don't use namespaced parameters Fabian Ebner
2022-07-20 10:59 ` [pve-devel] [RFC/PATCH pve-storage 1/1] api: pbs: file restore: " Fabian Ebner
2022-11-04 13:17 ` [pve-devel] applied: " Wolfgang Bumiller
2022-10-04 8:08 ` [pve-devel] [pmg-devel] [PATCH-SERIES pve-common/pmg-api/pve-storage] pbs client: rework namespace usage and minor fixes Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720105948.291740-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox