public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH proxmox-backup/common/storage/wt v2] add tar.zst download in pve
@ 2022-07-13  9:43 Dominik Csapak
  2022-07-13  9:43 ` [pve-devel] [PATCH proxmox-backup v2 1/4] file-restore: update dependencies Dominik Csapak
                   ` (7 more replies)
  0 siblings, 8 replies; 15+ messages in thread
From: Dominik Csapak @ 2022-07-13  9:43 UTC (permalink / raw)
  To: pbs-devel, pve-devel

like we have the tar.zst download button for pbs itself, add it for
pve for both vms and container file-restore

pve-storage depends on pve-common, which depends on proxmox-backup,
(we must add the recently bumped proxmox-compression as a
dependency; also for the restore-daemon)

changes from v1:
* split format into 'format' and 'zstd'
* also use those parameters for file-restore
  (keep 'tar' for the pve api for gui compatibility)
* use an '#[api]'  enum for the format type

i kept the 'tar' for the pve api, since that way it makes it easily
compatible with the current gui. I'd understand that we maybe also
here want to have the 'format'/'zst' options and simply pass them
through

in that case, we "have" to adapt the pbs-api too since there we already
have the 'tar' parameter, or we have  to have two codepaths for the gui
depending which api we want to use.

No problem for a v3 either way, there just was not really an feedback
on that in my previous versions.

proxmox-backup:

Dominik Csapak (4):
  file-restore: update dependencies
  pbs-api-types: add FileRestoreFormat type
  restore-daemon: add 'format' and 'zstd' parameters to the 'extract'
    handler
  file-restore: add 'format' and 'zstd' parameters to 'extract' command

 pbs-api-types/src/file_restore.rs             |  15 +++
 proxmox-file-restore/Cargo.toml               |   4 +-
 proxmox-file-restore/src/block_driver.rs      |  12 ++-
 proxmox-file-restore/src/block_driver_qemu.rs |  15 +--
 proxmox-file-restore/src/main.rs              | 100 +++++++++++++++---
 .../src/proxmox_restore_daemon/api.rs         |  46 ++++++--
 6 files changed, 157 insertions(+), 35 deletions(-)

pve-common:

Dominik Csapak (1):
  PBSClient: add 'tar' parameter to file_restore_extract

 src/PVE/PBSClient.pm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

pve-storage:

Dominik Csapak (1):
  api/filerestore: add 'tar' parameter to 'download' api

 PVE/API2/Storage/FileRestore.pm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

proxmox-widget-toolkit:

Dominik Csapak (1):
  window/FileBrowser: enable tar button by default

 src/window/FileBrowser.js | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

-- 
2.30.2





^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2023-10-19  7:20 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13  9:43 [pve-devel] [PATCH proxmox-backup/common/storage/wt v2] add tar.zst download in pve Dominik Csapak
2022-07-13  9:43 ` [pve-devel] [PATCH proxmox-backup v2 1/4] file-restore: update dependencies Dominik Csapak
2022-10-05 16:51   ` [pve-devel] [pbs-devel] " Thomas Lamprecht
2022-10-05 16:53     ` Thomas Lamprecht
2022-07-13  9:43 ` [pve-devel] [PATCH proxmox-backup v2 2/4] pbs-api-types: add FileRestoreFormat type Dominik Csapak
2022-10-05 16:51   ` [pve-devel] applied: [pbs-devel] " Thomas Lamprecht
2022-10-05 16:52   ` Thomas Lamprecht
2022-07-13  9:43 ` [pve-devel] [PATCH proxmox-backup v2 3/4] restore-daemon: add 'format' and 'zstd' parameters to the 'extract' handler Dominik Csapak
2022-10-05 16:54   ` [pve-devel] applied: [pbs-devel] " Thomas Lamprecht
2022-07-13  9:43 ` [pve-devel] [PATCH proxmox-backup v2 4/4] file-restore: add 'format' and 'zstd' parameters to 'extract' command Dominik Csapak
2022-10-05 16:54   ` [pve-devel] applied: [pbs-devel] " Thomas Lamprecht
2022-07-13  9:43 ` [pve-devel] [PATCH common v2 1/1] PBSClient: add 'tar' parameter to file_restore_extract Dominik Csapak
2022-07-13  9:43 ` [pve-devel] [PATCH storage v2 1/1] api/filerestore: add 'tar' parameter to 'download' api Dominik Csapak
2022-07-13  9:43 ` [pve-devel] [PATCH widget-toolkit v2 1/1] window/FileBrowser: enable tar button by default Dominik Csapak
2023-10-19  7:20 ` [pve-devel] [PATCH proxmox-backup/common/storage/wt v2] add tar.zst download in pve Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal