From: Stefan Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2] fix: make 'ceph-volume' conditional on quincy install
Date: Mon, 4 Jul 2022 17:45:17 +0200 [thread overview]
Message-ID: <20220704154517.561889-1-s.sterz@proxmox.com> (raw)
when installing non-quincy versions, 'ceph-volume' is not contained in
the respective repositories and, thus, the install process would fail.
Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
tested this by installing octopus, pacific and quincy. same issues as
before.
PVE/CLI/pveceph.pm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm
index a85df130..5c21bf7e 100755
--- a/PVE/CLI/pveceph.pm
+++ b/PVE/CLI/pveceph.pm
@@ -176,13 +176,17 @@ __PACKAGE__->register_method ({
my @ceph_packages = qw(
ceph
ceph-common
- ceph-volume
ceph-mds
ceph-fuse
gdisk
nvme-cli
);
+ # when installing versions older than quincy, 'ceph-volume' does not exists. don't include it
+ if ($cephver ne 'octopus' and $cephver ne 'pacific') {
+ push @ceph_packages, 'ceph-volume';
+ }
+
print "start installation\n";
# this flag helps to determine when apt is actually done installing (vs. partial extracing)
--
2.30.2
next reply other threads:[~2022-07-04 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 15:45 Stefan Sterz [this message]
2022-07-05 6:43 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220704154517.561889-1-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox