From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Matthias Heiserer <m.heiserer@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH qemu-server] Qemu-Server: fix wrong quotation
Date: Thu, 30 Jun 2022 12:33:37 +0200 [thread overview]
Message-ID: <20220630103337.hjnb7xyvgkltg76p@casey.proxmox.com> (raw)
In-Reply-To: <20220630101203.728575-1-m.heiserer@proxmox.com>
applied, thanks
On Thu, Jun 30, 2022 at 12:12:03PM +0200, Matthias Heiserer wrote:
> Before, the two strings were one single string each, rather than multiple
> separated by newlines.
>
> In the docs, this looked very strange as there were linebreaks and the
> dots were shown. Can be seen e.g. in api-viewer /nodes/{node}/qemu/{vmid}/config.
>
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> PVE/QemuServer.pm | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 09c0df4..7d9cf22 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -783,16 +783,16 @@ my $confdesc_cloudinit = {
> searchdomain => {
> optional => 1,
> type => 'string',
> - description => "cloud-init: Sets DNS search domains for a container. Create will'
> + description => 'cloud-init: Sets DNS search domains for a container. Create will'
> .' automatically use the setting from the host if neither searchdomain nor nameserver'
> - .' are set.",
> + .' are set.',
> },
> nameserver => {
> optional => 1,
> type => 'string', format => 'address-list',
> - description => "cloud-init: Sets DNS server IP address for a container. Create will'
> + description => 'cloud-init: Sets DNS server IP address for a container. Create will'
> .' automatically use the setting from the host if neither searchdomain nor nameserver'
> - .' are set.",
> + .' are set.',
> },
> sshkeys => {
> optional => 1,
> --
> 2.30.2
prev parent reply other threads:[~2022-06-30 10:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 10:12 [pve-devel] " Matthias Heiserer
2022-06-30 10:33 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630103337.hjnb7xyvgkltg76p@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox