public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server] Qemu-Server: fix wrong quotation
@ 2022-06-30 10:12 Matthias Heiserer
  2022-06-30 10:33 ` [pve-devel] applied: " Wolfgang Bumiller
  0 siblings, 1 reply; 2+ messages in thread
From: Matthias Heiserer @ 2022-06-30 10:12 UTC (permalink / raw)
  To: pve-devel

Before, the two strings were one single string each, rather than multiple
separated by newlines.

In the docs, this looked very strange as there were linebreaks and the
dots were shown. Can be seen e.g. in api-viewer /nodes/{node}/qemu/{vmid}/config.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 PVE/QemuServer.pm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 09c0df4..7d9cf22 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -783,16 +783,16 @@ my $confdesc_cloudinit = {
     searchdomain => {
 	optional => 1,
 	type => 'string',
-	description => "cloud-init: Sets DNS search domains for a container. Create will'
+	description => 'cloud-init: Sets DNS search domains for a container. Create will'
 	    .' automatically use the setting from the host if neither searchdomain nor nameserver'
-	    .' are set.",
+	    .' are set.',
     },
     nameserver => {
 	optional => 1,
 	type => 'string', format => 'address-list',
-	description => "cloud-init: Sets DNS server IP address for a container. Create will'
+	description => 'cloud-init: Sets DNS server IP address for a container. Create will'
 	    .' automatically use the setting from the host if neither searchdomain nor nameserver'
-	    .' are set.",
+	    .' are set.',
     },
     sshkeys => {
 	optional => 1,
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH qemu-server] Qemu-Server: fix wrong quotation
  2022-06-30 10:12 [pve-devel] [PATCH qemu-server] Qemu-Server: fix wrong quotation Matthias Heiserer
@ 2022-06-30 10:33 ` Wolfgang Bumiller
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Bumiller @ 2022-06-30 10:33 UTC (permalink / raw)
  To: Matthias Heiserer; +Cc: pve-devel

applied, thanks

On Thu, Jun 30, 2022 at 12:12:03PM +0200, Matthias Heiserer wrote:
> Before, the two strings were one single string each, rather than multiple
> separated by newlines.
> 
> In the docs, this looked very strange as there were linebreaks and the
> dots were shown. Can be seen e.g. in api-viewer /nodes/{node}/qemu/{vmid}/config.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>  PVE/QemuServer.pm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 09c0df4..7d9cf22 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -783,16 +783,16 @@ my $confdesc_cloudinit = {
>      searchdomain => {
>  	optional => 1,
>  	type => 'string',
> -	description => "cloud-init: Sets DNS search domains for a container. Create will'
> +	description => 'cloud-init: Sets DNS search domains for a container. Create will'
>  	    .' automatically use the setting from the host if neither searchdomain nor nameserver'
> -	    .' are set.",
> +	    .' are set.',
>      },
>      nameserver => {
>  	optional => 1,
>  	type => 'string', format => 'address-list',
> -	description => "cloud-init: Sets DNS server IP address for a container. Create will'
> +	description => 'cloud-init: Sets DNS server IP address for a container. Create will'
>  	    .' automatically use the setting from the host if neither searchdomain nor nameserver'
> -	    .' are set.",
> +	    .' are set.',
>      },
>      sshkeys => {
>  	optional => 1,
> -- 
> 2.30.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-30 10:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-30 10:12 [pve-devel] [PATCH qemu-server] Qemu-Server: fix wrong quotation Matthias Heiserer
2022-06-30 10:33 ` [pve-devel] applied: " Wolfgang Bumiller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal