* [pve-devel] [PATCH manager] ui: manual backup: unescape notes template on load
@ 2022-06-27 12:42 Fabian Ebner
2022-06-28 14:10 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Ebner @ 2022-06-27 12:42 UTC (permalink / raw)
To: pve-devel
It's escaped in the API result and will be re-escaped upon submit,
leading to confusion as reported in the community forum:
https://forum.proxmox.com/threads/110747/post-480507
Fixes: 2a1f46ed ("ui: manual backup: also set notes-template default")
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
www/manager6/window/Backup.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 510430c0..4b21c746 100644
--- a/www/manager6/window/Backup.js
+++ b/www/manager6/window/Backup.js
@@ -114,8 +114,9 @@ Ext.define('PVE.window.Backup', {
modeSelector.setValue(data.mode);
}
if (!initialDefaults && (data['notes-template'] ?? false)) {
- me.down('field[name=notes-template]')
- .setValue(data['notes-template']);
+ me.down('field[name=notes-template]').setValue(
+ PVE.Utils.unEscapeNotesTemplate(data['notes-template']),
+ );
}
initialDefaults = true;
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: manual backup: unescape notes template on load
2022-06-27 12:42 [pve-devel] [PATCH manager] ui: manual backup: unescape notes template on load Fabian Ebner
@ 2022-06-28 14:10 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-06-28 14:10 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Ebner
On 27/06/2022 14:42, Fabian Ebner wrote:
> It's escaped in the API result and will be re-escaped upon submit,
> leading to confusion as reported in the community forum:
> https://forum.proxmox.com/threads/110747/post-480507
>
> Fixes: 2a1f46ed ("ui: manual backup: also set notes-template default")
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> www/manager6/window/Backup.js | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-28 14:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-27 12:42 [pve-devel] [PATCH manager] ui: manual backup: unescape notes template on load Fabian Ebner
2022-06-28 14:10 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox