From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied-series: [RFC/PATCH v2 qemu 1/3] PVE-Backup: create jobs: correctly cancel in error scenario
Date: Wed, 8 Jun 2022 14:04:23 +0200 [thread overview]
Message-ID: <20220608120423.ywgtxfs6cwkd7pbz@casey.proxmox.com> (raw)
In-Reply-To: <20220525115939.347193-1-f.ebner@proxmox.com>
On Wed, May 25, 2022 at 01:59:37PM +0200, Fabian Ebner wrote:
> The first call to job_cancel_sync() will cancel and free all jobs in
> the transaction, so ensure that it's called only once and get rid of
> the job_unref() that would operate on freed memory.
>
> It's also necessary to NULL backup_state.pbs in the error scenario,
> because a subsequent backup_cancel QMP call (as happens in PVE when
> the backup QMP command fails) would try to call proxmox_backup_abort()
> and run into a segfault.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Series LGTM, applied, thanks
prev parent reply other threads:[~2022-06-08 12:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 11:59 [pve-devel] " Fabian Ebner
2022-05-25 11:59 ` [pve-devel] [RFC/PATCH v2 qemu 2/3] PVE-Backup: ensure jobs in di_list are referenced Fabian Ebner
2022-05-25 11:59 ` [pve-devel] [RFC/PATCH v2 qemu 3/3] PVE-Backup: avoid segfault issues upon backup-cancel Fabian Ebner
2022-06-08 12:04 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608120423.ywgtxfs6cwkd7pbz@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox