public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-widget-toolkit/pve-storage] replace '(mounted)' string by boolean field
Date: Wed,  8 Jun 2022 07:09:58 +0000	[thread overview]
Message-ID: <20220608071000.3852-1-h.laimer@proxmox.com> (raw)

The mounted status of a disk/partition is now a separate column instead
of the '(mounted)' that is added to the usage string. This change seems
reasonable on its own, but it is mostly so the UI works properly with
the data that will be returned from the PBS api.
We could also return the mountpoint instead of a boolean, the data is
already there, but I'm not sure if that's something that makes sense to
display in the grid, might end up looking a little 'cluttered'.


* pve-storage
Hannes Laimer (1):
  api2: disks: add mounted boolean field

 PVE/API2/Disks.pm | 1 +
 PVE/Diskmanage.pm | 7 +++----
 2 files changed, 4 insertions(+), 4 deletions(-)

* proxmox-widget-toolkit
Hannes Laimer (1):
  ui: disks: add 'mounted' column

 src/panel/DiskList.js | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

-- 
2.30.2





             reply	other threads:[~2022-06-08  7:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08  7:09 Hannes Laimer [this message]
2022-06-08  7:09 ` [pve-devel] [PATCH pve-storage 1/1] api2: disks: add mounted " Hannes Laimer
2022-06-15  8:24   ` [pve-devel] applied: " Wolfgang Bumiller
2022-06-08  7:10 ` [pve-devel] [PATCH proxmox-widget-toolkit 1/1] ui: disks: add 'mounted' column Hannes Laimer
2022-06-15  8:58   ` [pve-devel] applied: " Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220608071000.3852-1-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal