public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager 2/3] fix #3967: enable ZFS dRAID creation in WebGUI
Date: Thu,  2 Jun 2022 13:22:33 +0200	[thread overview]
Message-ID: <20220602112234.1868726-3-s.hrdlicka@proxmox.com> (raw)
In-Reply-To: <20220602112234.1868726-1-s.hrdlicka@proxmox.com>

add fields for additional settings required by ZFS dRAID

Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
---
requires the changes in pve-storageto work

 www/manager6/node/ZFS.js | 47 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/www/manager6/node/ZFS.js b/www/manager6/node/ZFS.js
index 5b3bdbda..5f3bbfef 100644
--- a/www/manager6/node/ZFS.js
+++ b/www/manager6/node/ZFS.js
@@ -42,6 +42,9 @@ Ext.define('PVE.node.CreateZFS', {
 			    fieldLabel: gettext('RAID Level'),
 			    name: 'raidlevel',
 			    value: 'single',
+			    listeners: {
+				change: 'onTargetChange',
+			    },
 			    comboItems: [
 				['single', gettext('Single Disk')],
 				['mirror', 'Mirror'],
@@ -49,8 +52,29 @@ Ext.define('PVE.node.CreateZFS', {
 				['raidz', 'RAIDZ'],
 				['raidz2', 'RAIDZ2'],
 				['raidz3', 'RAIDZ3'],
+				['draid', 'dRAID'],
+				['draid2', 'dRAID2'],
+				['draid3', 'dRAID3'],
 			    ],
 			},
+			{
+			    xtype: 'proxmoxintegerfield',
+			    fieldLabel: gettext('DRAID data devices'),
+			    minValue: 1,
+			    disabled: true,
+			    hidden: true,
+			    reference: 'draiddata',
+			    name: 'draiddata',
+			},
+			{
+			    xtype: 'proxmoxintegerfield',
+			    fieldLabel: gettext('DRAID spares'),
+			    minValue: 0,
+			    disabled: true,
+			    hidden: true,
+			    reference: 'draidspares',
+			    name: 'draidspares',
+			},
 			{
 			    xtype: 'proxmoxKVComboBox',
 			    fieldLabel: gettext('Compression'),
@@ -101,6 +125,29 @@ Ext.define('PVE.node.CreateZFS', {
 
         me.callParent();
     },
+
+    controller: {
+	xclass: 'Ext.app.ViewController',
+
+	onTargetChange: function(selection) {
+	    var me = this;
+	    var dataField = me.lookupReference('draiddata');
+	    var sparesField = me.lookupReference('draidspares');
+	    if (selection.value.startsWith("draid")) {
+		//show draid settings
+		dataField.setVisible(true);
+		dataField.setDisabled(false);
+		sparesField.setVisible(true);
+		sparesField.setDisabled(false);
+	    } else {
+		//hide draid settings
+		dataField.setVisible(false);
+		dataField.setDisabled(true);
+		sparesField.setVisible(false);
+		sparesField.setDisabled(true);
+	    }
+	},
+    },
 });
 
 Ext.define('PVE.node.ZFSList', {
-- 
2.30.2





  parent reply	other threads:[~2022-06-02 11:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02 11:22 [pve-devel] [PATCH SERIES storage/manager/docs 0/3] add ZFS dRAID creation Stefan Hrdlicka
2022-06-02 11:22 ` [pve-devel] [PATCH pve-storage 1/3] fix #3967: enable ZFS dRAID creation via API Stefan Hrdlicka
2022-06-03 12:20   ` Dominik Csapak
2022-06-03 12:31   ` Dominik Csapak
2022-06-03 12:45     ` Dominik Csapak
2022-06-02 11:22 ` Stefan Hrdlicka [this message]
2022-06-03 12:24   ` [pve-devel] [PATCH pve-manager 2/3] fix #3967: enable ZFS dRAID creation in WebGUI Dominik Csapak
2022-06-07 14:41     ` Stefan Hrdlicka
2022-06-02 11:22 ` [pve-devel] [PATCH pve-docs 3/3] fix #3967: add ZFS dRAID documentation Stefan Hrdlicka
2022-06-02 12:47   ` Matthias Heiserer
2022-06-03 14:12     ` Thomas Lamprecht
2022-06-03 12:34   ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220602112234.1868726-3-s.hrdlicka@proxmox.com \
    --to=s.hrdlicka@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal