From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage v2 2/2] BTRFSPlugin: reuse DirPlugin update/get_volume_attribute
Date: Thu, 2 Jun 2022 10:07:14 +0200 [thread overview]
Message-ID: <20220602080714.ijtp3ibkhxw67e66@casey.proxmox.com> (raw)
In-Reply-To: <20220602080332.wi62gyvno3wein3h@casey.proxmox.com>
On Thu, Jun 02, 2022 at 10:03:32AM +0200, Wolfgang Bumiller wrote:
> On Thu, Jun 02, 2022 at 09:14:59AM +0200, Thomas Lamprecht wrote:
> > Am 27/05/2022 um 14:31 schrieb Dominik Csapak:
> > > this allows setting notes+protected for backups on btrfs
> > >
> > > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> > > ---
> > > PVE/Storage/BTRFSPlugin.pm | 11 +++++++++--
> > > 1 file changed, 9 insertions(+), 2 deletions(-)
> >
> > looks OK, but the whole situation with that and often also btrfs is sometimes
> > a bit weird in subtle ways, so a quick look from you wolfgang would be appreciated.
>
> I'm a bit confused about the `get/update_volume_notes` subs.
> You said they are deprecated and unused. However, the DirPlugin does
> call it when `$attribute eq "notes"` in `get/update_volume_attribute`.
>
> Since BTRFSPlugin uses Plugin as a base and not DirPlugin and we pass
> $class (== BTRFSPlugin) to it, setting notes should not work with this patch?
Nevermind, I didn't read the 1st patch properly, those aren't called via
$class anymore.
Acked-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
prev parent reply other threads:[~2022-06-02 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 12:31 [pve-devel] [PATCH storage v2 1/2] DirPlugin: update_volume_attribute: don't use update_volume_notes Dominik Csapak
2022-05-27 12:31 ` [pve-devel] [PATCH storage v2 2/2] BTRFSPlugin: reuse DirPlugin update/get_volume_attribute Dominik Csapak
2022-06-02 7:14 ` Thomas Lamprecht
2022-06-02 8:03 ` Wolfgang Bumiller
2022-06-02 8:07 ` Dominik Csapak
2022-06-02 8:07 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602080714.ijtp3ibkhxw67e66@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox