From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Cc: t.lamprecht@proxmox.com, Alexandre Derumier <aderumier@odiso.com>
Subject: [pve-devel] [PATCH pve-cluster 1/1] add pve2-metrics rrd (single metrics)
Date: Wed, 1 Jun 2022 10:12:44 +0200 [thread overview]
Message-ID: <20220601081253.2542697-2-aderumier@odiso.com> (raw)
In-Reply-To: <20220601081253.2542697-1-aderumier@odiso.com>
This create 1 single rrd for each metric
allowed paths:
pve2-metrics/vms/<vmid>/<metric>
pve2-metrics/nodes/<node>/<metric>
pve2-metrics/storages/<node>/<storage>/<metric>
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
data/src/status.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/data/src/status.c b/data/src/status.c
index 9bceaeb..75ab89e 100644
--- a/data/src/status.c
+++ b/data/src/status.c
@@ -1097,6 +1097,23 @@ static const char *rrd_def_storage[] = {
NULL,
};
+static const char *rrd_def_metric[] = {
+ "DS:metric:GAUGE:120:0:U",
+
+ "RRA:AVERAGE:0.5:1:70", // 1 min avg - one hour
+ "RRA:AVERAGE:0.5:30:70", // 30 min avg - one day
+ "RRA:AVERAGE:0.5:180:70", // 3 hour avg - one week
+ "RRA:AVERAGE:0.5:720:70", // 12 hour avg - one month
+ "RRA:AVERAGE:0.5:10080:70", // 7 day avg - ony year
+
+ "RRA:MAX:0.5:1:70", // 1 min max - one hour
+ "RRA:MAX:0.5:30:70", // 30 min max - one day
+ "RRA:MAX:0.5:180:70", // 3 hour max - one week
+ "RRA:MAX:0.5:720:70", // 12 hour max - one month
+ "RRA:MAX:0.5:10080:70", // 7 day max - ony year
+ NULL,
+};
+
#define RRDDIR "/var/lib/rrdcached/db"
static void
@@ -1173,6 +1190,40 @@ update_rrd_data(
create_rrd_file(filename, argcount, rrd_def_node);
}
+ } else if ((strncmp(key, "pve2-metrics/", 13) == 0)) {
+ const char *path = key + 13;
+ char **pa = g_strsplit(path, "/", -1);
+
+ if (!pa[0] || !pa[1] || !pa[2] || strlen(pa[1]) < 1 || strlen(pa[2]) < 1) {
+ goto keyerror;
+ } else {
+ if (strcmp(pa[0], "vms") == 0 || strcmp(pa[0], "nodes") == 0) {
+ if (pa[3]) {
+ goto keyerror;
+ }
+ } else if (strcmp(pa[0], "storages") == 0) {
+ if (pa[4] || !pa[3] || strlen(pa[3]) < 1) {
+ goto keyerror;
+ }
+ } else {
+ goto keyerror;
+ }
+ }
+ g_strfreev(pa);
+
+
+ filename = g_strdup_printf(RRDDIR "/%s", key);
+
+ if (!g_file_test(filename, G_FILE_TEST_EXISTS)) {
+
+ char *dir = g_path_get_dirname(filename);
+ g_mkdir_with_parents(dir, 0755);
+ g_free(dir);
+
+ int argcount = sizeof(rrd_def_metric)/sizeof(void*) - 1;
+ create_rrd_file(filename, argcount, rrd_def_metric);
+ }
+
} else if ((strncmp(key, "pve2-vm/", 8) == 0) ||
(strncmp(key, "pve2.3-vm/", 10) == 0)) {
const char *vmid;
--
2.30.2
next prev parent reply other threads:[~2022-06-01 8:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 8:12 [pve-devel] [PATCH-SERIES common/qemu-server/lxc/manager] brodcast new metric stats in kvstore Alexandre Derumier
2022-06-01 8:12 ` Alexandre Derumier [this message]
2022-06-01 8:12 ` [pve-devel] [PATCH pve-common 1/2] cgroup: get_pressure_stat: use controllers in get_path Alexandre Derumier
2022-06-01 8:12 ` [pve-devel] [PATCH pve-manager 1/4] pvestatd: add broadcast_balancer_stats Alexandre Derumier
2022-06-01 8:12 ` [pve-devel] [PATCH pve-manager 1/3] pvestatd: qemu/lxc/host : broadcast rrd pressure metrics Alexandre Derumier
2022-06-01 8:12 ` [pve-devel] [PATCH pve-common 2/2] cgroup: get_pressure_stat: add cpu full pressure Alexandre Derumier
2022-06-01 8:12 ` [pve-devel] [PATCH pve-manager 2/4] pvestatd: qemu/lxc/node : add pressure stats Alexandre Derumier
2022-06-01 8:12 ` [pve-devel] [PATCH qemu-server 2/3] vmstatus: add hostmem value Alexandre Derumier
2022-06-01 8:12 ` [pve-devel] [PATCH pve-manager 3/4] pvestatd: qemu/lxc/node : add hostcpu/hostmem average stats Alexandre Derumier
2022-06-01 8:12 ` [pve-devel] [PATCH qemu-server 3/3] vmstatus: add pressure stats Alexandre Derumier
2022-06-01 8:12 ` [pve-devel] [PATCH pve-manager 4/4] pvestatd: node : broadcast ksm value Alexandre Derumier
-- strict thread matches above, loose matches on Subject: below --
2022-05-25 6:52 [pve-devel] [PATCH-SERIES cluster/common/qemu-server/lxc/manager] add new metric stats in single rrd Alexandre Derumier
2022-05-25 6:52 ` [pve-devel] [PATCH pve-cluster 1/1] add pve2-metrics rrd (single metrics) Alexandre Derumier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220601081253.2542697-2-aderumier@odiso.com \
--to=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox