public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit] fix #3930: gui: Stop text from overflowing for long words
Date: Fri, 27 May 2022 16:06:27 +0200	[thread overview]
Message-ID: <20220527140627.254734-1-d.tschlatscher@proxmox.com> (raw)

In the case where a status message would include a word that exceeds
the line length it would simply overflow and as the MessageBox does
not allow scrolling, there was no obvious way to read/access that part
of the sentence.
overflow-wrap: break-word fixes this quite elegantly as it only breaks
a word if it doesn't fit in it's own line.

This mostly affects the error message when adding a PBS in the storage
tab and the fingerprint is not set. Now it is possible to simply copy
it from the error message.
AFAICT the style override does not break any styling for the status
and error message modals in the PVE, PMG and PBS.

Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
---
 src/Toolkit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/Toolkit.js b/src/Toolkit.js
index a1d291e..450a3bc 100644
--- a/src/Toolkit.js
+++ b/src/Toolkit.js
@@ -718,6 +718,7 @@ Ext.onReady(function() {
 	    return this.show(config);
 	    }
 	},
+	style: "overflow-wrap: break-word;",
     });
 });
 Ext.define('Ext.ux.IFrame', {
-- 
2.30.2





                 reply	other threads:[~2022-05-27 14:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220527140627.254734-1-d.tschlatscher@proxmox.com \
    --to=d.tschlatscher@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal