From: Matthias Heiserer <m.heiserer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-cluster] Change log statements to debug
Date: Fri, 27 May 2022 11:37:25 +0200 [thread overview]
Message-ID: <20220527093725.328135-1-m.heiserer@proxmox.com> (raw)
They have been commented with //fixme for more than 11 years
and contain little information, so at least make them debug logs.
Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
data/src/logger.c | 2 +-
data/src/status.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/data/src/logger.c b/data/src/logger.c
index 619e1f6..c4fcdaa 100644
--- a/data/src/logger.c
+++ b/data/src/logger.c
@@ -626,7 +626,7 @@ clusterlog_insert(
if (dedup_lookup(cl->dedup, entry)) {
clog_copy(cl->base, entry);
} else {
- cfs_message("ignore duplicate"); // fixme remove
+ cfs_debug("ignore duplicate"); // fixme remove
}
g_mutex_unlock(&cl->mutex);
diff --git a/data/src/status.c b/data/src/status.c
index 9bceaeb..5e39109 100644
--- a/data/src/status.c
+++ b/data/src/status.c
@@ -1668,7 +1668,7 @@ dfsm_deliver(
cfs_critical("cant parse update message");
}
} else if (msg_type == KVSTORE_MESSAGE_LOG) {
- cfs_message("received log"); // fixme: remove
+ cfs_debug("received log"); // fixme: remove
const clog_entry_t *entry;
if ((entry = kvstore_parse_log_message(msg, msg_len))) {
clusterlog_insert(cfs_status.clusterlog, entry);
--
2.30.2
next reply other threads:[~2022-05-27 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 9:37 Matthias Heiserer [this message]
2022-05-28 7:22 ` Thomas Lamprecht
2022-06-01 14:22 ` Matthias Heiserer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220527093725.328135-1-m.heiserer@proxmox.com \
--to=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox