[pve-devel] [PATCH v2 storage] rbd: fix #4060 show data-pool usage when configured

[pve-devel] [PATCH v2 storage] rbd: fix #4060 show data-pool usage when configured

[Aaron Lauterer]

When a data-pool is configured, use it for status infos. The 'data-pool'
config option is used to mark the erasure coded pool while the 'pool'
will be the replicated pool holding meta data such as the omap.

This means, the 'pool' will only use a small amount of space and people
are interested how much they can store in the erasure coded pool anyway.

Therefore this patch reorders the assignment of the used pool name by
availability of the scfg parameters: data-pool -> pool -> fallback 'rbd'

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
changes: instead of two lines and if conditions, use the // parameter
multiple times

 PVE/Storage/RBDPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm
index fb48c3f..3511914 100644
--- a/PVE/Storage/RBDPlugin.pm
+++ b/PVE/Storage/RBDPlugin.pm
@@ -630,7 +630,7 @@ sub status {
     my $rados = $librados_connect->($scfg, $storeid);
     my $df = $rados->mon_command({ prefix => 'df', format => 'json' });
 
-    my $pool =  $scfg->{pool} ? $scfg->{pool} : 'rbd';
+    my $pool = $scfg->{'data-pool'} // $scfg->{pool} // 'rbd';
 
     my ($d) = grep { $_->{name} eq $pool } @{$df->{pools}};
 
-- 
2.30.2

[pve-devel] applied: Re: [PATCH v2 storage] rbd: fix #4060 show data-pool usage when configured

[Thomas Lamprecht]

On 18/05/2022 11:04, Aaron Lauterer wrote:
> When a data-pool is configured, use it for status infos. The 'data-pool'
> config option is used to mark the erasure coded pool while the 'pool'
> will be the replicated pool holding meta data such as the omap.
> 
> This means, the 'pool' will only use a small amount of space and people
> are interested how much they can store in the erasure coded pool anyway.
> 
> Therefore this patch reorders the assignment of the used pool name by
> availability of the scfg parameters: data-pool -> pool -> fallback 'rbd'
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> changes: instead of two lines and if conditions, use the // parameter
> multiple times
> 
>  PVE/Storage/RBDPlugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!