From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit] file browser: show "Download" button by default and disable both initially
Date: Tue, 17 May 2022 14:20:22 +0200 [thread overview]
Message-ID: <20220517122022.92528-1-f.ebner@proxmox.com> (raw)
Previously, the "Download As" button/menu would show initially and
clicking it had no effect. In PVE, this was noticeable and confusing.
In PBS, the rootdir is already auto-selected when the store loads.
Since the button changes automatically with the selection, the issue
was not noticeable there.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
src/window/FileBrowser.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/window/FileBrowser.js b/src/window/FileBrowser.js
index a519d6b..8db7c51 100644
--- a/src/window/FileBrowser.js
+++ b/src/window/FileBrowser.js
@@ -308,12 +308,13 @@ Ext.define("Proxmox.window.FileBrowser", {
handler: 'downloadZip',
reference: 'downloadBtn',
disabled: true,
- hidden: true,
},
{
text: gettext('Download as'),
xtype: 'button',
reference: 'menuBtn',
+ disabled: true,
+ hidden: true,
menu: {
items: [
{
--
2.30.2
reply other threads:[~2022-05-17 12:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517122022.92528-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox