public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 0/2] cifs plugin - add options parameter
Date: Fri, 13 May 2022 15:55:48 +0200	[thread overview]
Message-ID: <20220513135550.1856651-1-s.hrdlicka@proxmox.com> (raw)

This adds the options parameter to the CIFS plugin.

check propertyList is common for all plugins and it is therefore
not possible to have options twice with different descriptions. This patch moves
the options property from NFSPlugin.pm to the Plugin.pm level. The options
parameter has the same use for NFS & CIFS so it shouldn't be confusing
that they share it.

# pve-storage 
---
 PVE/Storage/CIFSPlugin.pm | 10 ++++++++--
 PVE/Storage/NFSPlugin.pm  |  4 ----
 PVE/Storage/Plugin.pm     |  6 ++++++
 3 files changed, 14 insertions(+), 6 deletions(-)

# pve-docs
---
 pve-storage-cifs.adoc | 5 +++++
 1 file changed, 5 insertions(+)


-- 
2.30.2




             reply	other threads:[~2022-05-13 13:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13 13:55 Stefan Hrdlicka [this message]
2022-05-13 13:55 ` [pve-devel] [PATCH storage 1/2] add options parameter to cifs plugin (fixes #2920) Stefan Hrdlicka
2022-07-28 10:26   ` Fiona Ebner
2022-05-13 13:55 ` [pve-devel] [PATCH docs 2/2] cifs: add options parameter (fix #2920) Stefan Hrdlicka
2022-07-28 10:26   ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220513135550.1856651-1-s.hrdlicka@proxmox.com \
    --to=s.hrdlicka@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal