From: Matthias Heiserer <m.heiserer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 manager 1/2] HDEdit: check iothread by default and move it from advanced section
Date: Thu, 12 May 2022 11:24:13 +0200 [thread overview]
Message-ID: <20220512092416.137095-1-m.heiserer@proxmox.com> (raw)
Existing disks are not changed by this.
Especially in benchmarks, iothreads significantly improve IO performance.
Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
Changes from v2:
* also check iothread when adding a disk to an existing VM and
scsi single
* use bind instead of hardcoded true
www/manager6/qemu/HDEdit.js | 27 ++++++++++++++++++---------
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index c643ee73..adee2591 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -14,6 +14,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
data: {
isScsi: false,
isVirtIO: false,
+ isSCSISingle: false,
},
},
@@ -53,6 +54,12 @@ Ext.define('PVE.qemu.HDInputPanel', {
this.lookupReference('scsiController').setValue(vmScsiType);
},
},
+ 'field[name=scsiController]': {
+ change: function(f, value) {
+ let vm = this.getViewModel();
+ vm.set('isSCSISingle', value === 'virtio-scsi-single');
+ },
+ },
},
init: function(view) {
@@ -195,6 +202,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
me.scsiController = Ext.create('Ext.form.field.Display', {
fieldLabel: gettext('SCSI Controller'),
reference: 'scsiController',
+ name: 'scsiController',
bind: me.insideWizard ? {
value: '{current.scsihw}',
visible: '{isSCSI}',
@@ -251,6 +259,16 @@ Ext.define('PVE.qemu.HDInputPanel', {
reference: 'discard',
name: 'discard',
},
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'iothread',
+ fieldLabel: 'IO thread',
+ clearOnDisable: true,
+ bind: {
+ disabled: '{!isVirtIO && !isSCSI}',
+ value: '{isSCSISingle}',
+ },
+ },
);
advancedColumn1.push(
@@ -263,15 +281,6 @@ Ext.define('PVE.qemu.HDInputPanel', {
disabled: '{isVirtIO}',
},
},
- {
- xtype: 'proxmoxcheckbox',
- name: 'iothread',
- fieldLabel: 'IO thread',
- clearOnDisable: true,
- bind: {
- disabled: '{!isVirtIO && !isSCSI}',
- },
- },
{
xtype: 'proxmoxcheckbox',
name: 'readOnly', // `ro` in the config, we map in get/set values
--
2.30.2
next reply other threads:[~2022-05-12 9:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 9:24 Matthias Heiserer [this message]
2022-05-12 9:24 ` [pve-devel] [PATCH v3 qemu-server 1/2] bump pve-common Matthias Heiserer
2022-05-12 9:24 ` [pve-devel] [PATCH v3 manager 2/2] OS defaults: use SCSI single as default controller Matthias Heiserer
2022-05-12 9:24 ` [pve-devel] [PATCH v3 qemu-server 2/2] Warn in GUI for unlikely iothread config - fixes #3890 Matthias Heiserer
2022-05-18 9:44 ` Fabian Ebner
2022-05-18 9:40 ` [pve-devel] [PATCH v3 manager 1/2] HDEdit: check iothread by default and move it from advanced section Fabian Ebner
2022-05-19 13:35 ` Matthias Heiserer
2022-05-20 6:52 ` Fabian Ebner
2022-05-27 11:53 ` Matthias Heiserer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512092416.137095-1-m.heiserer@proxmox.com \
--to=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox