From: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 3/3] remove dependency on Term::ReadLine (see #2077)
Date: Mon, 9 May 2022 09:30:34 +0200 [thread overview]
Message-ID: <20220509073034.822117-4-s.hrdlicka@proxmox.com> (raw)
In-Reply-To: <20220509073034.822117-1-s.hrdlicka@proxmox.com>
depends on change in pve-common
Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
---
This wasn't in the ticket but I found the dependency here as well and
removed it.
PVE/CLI/qm.pm | 4 ++--
debian/control | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index cf0d6f3..9579967 100755
--- a/PVE/CLI/qm.pm
+++ b/PVE/CLI/qm.pm
@@ -12,7 +12,6 @@ use IO::Select;
use IO::Socket::UNIX;
use JSON;
use POSIX qw(strftime);
-use Term::ReadLine;
use URI::Escape;
use PVE::Cluster;
@@ -24,6 +23,7 @@ use PVE::Network;
use PVE::RPCEnvironment;
use PVE::SafeSyslog;
use PVE::Tools qw(extract_param);
+use PVE::PTY;
use PVE::API2::Qemu::Agent;
use PVE::API2::Qemu;
@@ -392,7 +392,7 @@ __PACKAGE__->register_method ({
my $term = Term::ReadLine->new('qm');
- while (defined(my $input = $term->readline('qm> '))) {
+ while (defined(my $input = PVE::PTY::read_input('qm> '))) {
chomp $input;
next if $input =~ m/^\s*$/;
last if $input =~ m/^\s*q(uit)?\s*$/;
diff --git a/debian/control b/debian/control
index 7de9e84..62869ac 100644
--- a/debian/control
+++ b/debian/control
@@ -38,7 +38,6 @@ Depends: dbus,
libpve-common-perl (>= 7.1-3),
libpve-guest-common-perl (>= 4.1-1),
libpve-storage-perl (>= 6.3-8),
- libterm-readline-gnu-perl,
libuuid-perl,
libxml-libxml-perl,
perl (>= 5.10.0-19),
--
2.30.2
prev parent reply other threads:[~2022-05-09 7:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 7:30 [pve-devel] [PATCH pve-common 0/3] remove dependency on Term::ReadLine Stefan Hrdlicka
2022-05-09 7:30 ` [pve-devel] [PATCH pve-common 1/3] remove dependency on Term::ReadLine (see #2077) Stefan Hrdlicka
2022-05-09 7:30 ` [pve-devel] [PATCH pve-manager 2/3] " Stefan Hrdlicka
2022-05-09 7:30 ` Stefan Hrdlicka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509073034.822117-4-s.hrdlicka@proxmox.com \
--to=s.hrdlicka@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox