[pve-devel] [PATCH manager 1/2] ui: manual backup: also set notes-template default

[pve-devel] [PATCH manager 1/2] ui: manual backup: also set notes-template default

[Fabian Ebner]

like is done for other vzdump options already.

Requested in the community forum:
https://forum.proxmox.com/threads/108970/#post-468655

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 www/manager6/window/Backup.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index f77e9ffa..a0ea0846 100644
--- a/www/manager6/window/Backup.js
+++ b/www/manager6/window/Backup.js
@@ -113,6 +113,10 @@ Ext.define('PVE.window.Backup', {
 			    if (!initialDefaults && data.mode !== undefined) {
 				modeSelector.setValue(data.mode);
 			    }
+			    if (!initialDefaults && (data['notes-template'] ?? false)) {
+				me.down('field[name=notes-template]')
+				    .setValue(data['notes-template']);
+			    }
 
 			    initialDefaults = true;
 
-- 
2.30.2

[pve-devel] [PATCH manager 2/2] configs: vzdump: add notes-template default

[Fabian Ebner]

so users can see that it can be configured here.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---

Causes a "configuration changed by distributor" dialogue when
upgrading the package.

 configs/vzdump.conf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/vzdump.conf b/configs/vzdump.conf
index a0075cfa..fe4b18ab 100644
--- a/configs/vzdump.conf
+++ b/configs/vzdump.conf
@@ -14,3 +14,4 @@
 #script: FILENAME
 #exclude-path: PATHLIST
 #pigz: N
+#notes-template: {{guestname}}
-- 
2.30.2

Re: [pve-devel] [PATCH manager 2/2] configs: vzdump: add notes-template default

[Fabian Ebner]

Am 09.05.22 um 09:17 schrieb Fabian Ebner:
> so users can see that it can be configured here.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Causes a "configuration changed by distributor" dialogue when
> upgrading the package.
> 
>  configs/vzdump.conf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/vzdump.conf b/configs/vzdump.conf
> index a0075cfa..fe4b18ab 100644
> --- a/configs/vzdump.conf
> +++ b/configs/vzdump.conf
> @@ -14,3 +14,4 @@
>  #script: FILENAME
>  #exclude-path: PATHLIST
>  #pigz: N
> +#notes-template: {{guestname}}

There's a cosmetic issue here. I get
parse error in '/etc/vzdump.conf' - 'storage': missing property -
'notes-template' requires this property
if notes-template is configured, but storage isn't. It still works, but
is very misleading. I'll work out a v2.

Re: [pve-devel] [PATCH manager 2/2] configs: vzdump: add notes-template default

[Thomas Lamprecht]

On 09/05/2022 09:17, Fabian Ebner wrote:
> so users can see that it can be configured here.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Causes a "configuration changed by distributor" dialogue when
> upgrading the package.
> 
>  configs/vzdump.conf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/vzdump.conf b/configs/vzdump.conf
> index a0075cfa..fe4b18ab 100644
> --- a/configs/vzdump.conf
> +++ b/configs/vzdump.conf
> @@ -14,3 +14,4 @@
>  #script: FILENAME
>  #exclude-path: PATHLIST
>  #pigz: N
> +#notes-template: {{guestname}}

not sure if a node specific config is a good place for this, I'd think no config
(frontend-only) or if we really want one then maybe datacenter.cfg so that its
cluster wide; we could alternatively also start supporting to have a pmxcfs hosted
vzdump.conf that is read too (node one would still take precedence if a setting
appears in both).

Re: [pve-devel] [PATCH manager 2/2] configs: vzdump: add notes-template default

[Fabian Ebner]

Am 09.05.22 um 13:52 schrieb Thomas Lamprecht:
> On 09/05/2022 09:17, Fabian Ebner wrote:
>> so users can see that it can be configured here.
>>
>> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
>> ---
>>
>> Causes a "configuration changed by distributor" dialogue when
>> upgrading the package.
>>
>>  configs/vzdump.conf | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/vzdump.conf b/configs/vzdump.conf
>> index a0075cfa..fe4b18ab 100644
>> --- a/configs/vzdump.conf
>> +++ b/configs/vzdump.conf
>> @@ -14,3 +14,4 @@
>>  #script: FILENAME
>>  #exclude-path: PATHLIST
>>  #pigz: N
>> +#notes-template: {{guestname}}
> 
> not sure if a node specific config is a good place for this, I'd think no config
> (frontend-only) or if we really want one then maybe datacenter.cfg so that its
> cluster wide; we could alternatively also start supporting to have a pmxcfs hosted
> vzdump.conf that is read too (node one would still take precedence if a setting
> appears in both).

Yes, adding a cluster-wide vzdump.conf could be worth it for such
options. I still think we can leverage the existing mechanism of the
node-specific defaults though. It already works for CLI and backup jobs
that don't set notes-template themselves.

It's just not filled-in the UI yet, like we do for mail address, backup
mode and prune-settings, the first two of which also don't feel very
node-specific to me. Of course having them be node-specific adds a
little bit of extra flexibility, but that'd apply to notes-template too.

This patch is just for documentation, but '{{guestname}}' is not the
back-end default, which the patch might suggest. It's probably better to
instead write
#notes-template: TEMPLATE-STRING