[pve-devel] [PATCH manager] ui: realm sync: let users set 'remove vanished options' independently

[pve-devel] [PATCH manager] ui: realm sync: let users set 'remove vanished options' independently

[Dominik Csapak]

and label it correctly. The 'Properties' option was mislabeled,
it means 'remove vanished fields from synced users', not 'remove
fields from vanished users'.

So don't couple that with the 'Entries' option, and update the label
to convey the right meaning.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/dc/AuthEditLDAP.js | 18 +-----------------
 www/manager6/dc/SyncWindow.js   |  2 +-
 2 files changed, 2 insertions(+), 18 deletions(-)

diff --git a/www/manager6/dc/AuthEditLDAP.js b/www/manager6/dc/AuthEditLDAP.js
index 4a0823af..96ef77b9 100644
--- a/www/manager6/dc/AuthEditLDAP.js
+++ b/www/manager6/dc/AuthEditLDAP.js
@@ -99,22 +99,6 @@ Ext.define('PVE.panel.LDAPSyncInputPanel', {
     extend: 'Proxmox.panel.InputPanel',
     xtype: 'pveAuthLDAPSyncPanel',
 
-    controller: {
-	xclass: 'Ext.app.ViewController',
-	control: {
-	    'proxmoxcheckbox[name=remove-vanished-entry]': {
-		change: function(_f, removeEntries) {
-		    let propertyField = this.getView()
-			.down('proxmoxcheckbox[name=remove-vanished-properties]');
-		    propertyField.setDisabled(removeEntries);
-		    if (removeEntries) {
-			propertyField.setValue(true);
-		    }
-		},
-	    },
-	},
-    },
-
     editableAttributes: ['email'],
     editableDefaults: ['scope', 'enable-new'],
     default_opts: {},
@@ -312,7 +296,7 @@ Ext.define('PVE.panel.LDAPSyncInputPanel', {
 		    xtype: 'proxmoxcheckbox',
 		    fieldLabel: gettext('Properties'),
 		    name: 'remove-vanished-properties',
-		    boxLabel: gettext('Remove properties from vanished users.'),
+		    boxLabel: gettext('Remove vanished properties from synced users.'),
 		},
 	    ],
 	},
diff --git a/www/manager6/dc/SyncWindow.js b/www/manager6/dc/SyncWindow.js
index 1d8bef8f..c46dd701 100644
--- a/www/manager6/dc/SyncWindow.js
+++ b/www/manager6/dc/SyncWindow.js
@@ -138,7 +138,7 @@ Ext.define('PVE.dc.SyncWindow', {
 				xtype: 'proxmoxcheckbox',
 				fieldLabel: gettext('Properties'),
 				name: 'remove-vanished-properties',
-				boxLabel: gettext('Remove properties from vanished users.'),
+				boxLabel: gettext('Remove vanished properties from synced users.'),
 			    },
 			],
 		    },
-- 
2.30.2

[pve-devel] applied: [PATCH manager] ui: realm sync: let users set 'remove vanished options' independently

[Thomas Lamprecht]

Am 5/2/22 um 15:15 schrieb Dominik Csapak:
> and label it correctly. The 'Properties' option was mislabeled,
> it means 'remove vanished fields from synced users', not 'remove
> fields from vanished users'.
> 
> So don't couple that with the 'Entries' option, and update the label
> to convey the right meaning.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/dc/AuthEditLDAP.js | 18 +-----------------
>  www/manager6/dc/SyncWindow.js   |  2 +-
>  2 files changed, 2 insertions(+), 18 deletions(-)
> 
>

applied, thanks!