From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: realm sync: let users set 'remove vanished options' independently
Date: Mon, 2 May 2022 15:15:20 +0200 [thread overview]
Message-ID: <20220502131520.3182327-1-d.csapak@proxmox.com> (raw)
and label it correctly. The 'Properties' option was mislabeled,
it means 'remove vanished fields from synced users', not 'remove
fields from vanished users'.
So don't couple that with the 'Entries' option, and update the label
to convey the right meaning.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/dc/AuthEditLDAP.js | 18 +-----------------
www/manager6/dc/SyncWindow.js | 2 +-
2 files changed, 2 insertions(+), 18 deletions(-)
diff --git a/www/manager6/dc/AuthEditLDAP.js b/www/manager6/dc/AuthEditLDAP.js
index 4a0823af..96ef77b9 100644
--- a/www/manager6/dc/AuthEditLDAP.js
+++ b/www/manager6/dc/AuthEditLDAP.js
@@ -99,22 +99,6 @@ Ext.define('PVE.panel.LDAPSyncInputPanel', {
extend: 'Proxmox.panel.InputPanel',
xtype: 'pveAuthLDAPSyncPanel',
- controller: {
- xclass: 'Ext.app.ViewController',
- control: {
- 'proxmoxcheckbox[name=remove-vanished-entry]': {
- change: function(_f, removeEntries) {
- let propertyField = this.getView()
- .down('proxmoxcheckbox[name=remove-vanished-properties]');
- propertyField.setDisabled(removeEntries);
- if (removeEntries) {
- propertyField.setValue(true);
- }
- },
- },
- },
- },
-
editableAttributes: ['email'],
editableDefaults: ['scope', 'enable-new'],
default_opts: {},
@@ -312,7 +296,7 @@ Ext.define('PVE.panel.LDAPSyncInputPanel', {
xtype: 'proxmoxcheckbox',
fieldLabel: gettext('Properties'),
name: 'remove-vanished-properties',
- boxLabel: gettext('Remove properties from vanished users.'),
+ boxLabel: gettext('Remove vanished properties from synced users.'),
},
],
},
diff --git a/www/manager6/dc/SyncWindow.js b/www/manager6/dc/SyncWindow.js
index 1d8bef8f..c46dd701 100644
--- a/www/manager6/dc/SyncWindow.js
+++ b/www/manager6/dc/SyncWindow.js
@@ -138,7 +138,7 @@ Ext.define('PVE.dc.SyncWindow', {
xtype: 'proxmoxcheckbox',
fieldLabel: gettext('Properties'),
name: 'remove-vanished-properties',
- boxLabel: gettext('Remove properties from vanished users.'),
+ boxLabel: gettext('Remove vanished properties from synced users.'),
},
],
},
--
2.30.2
next reply other threads:[~2022-05-02 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 13:15 Dominik Csapak [this message]
2022-05-02 13:42 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502131520.3182327-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox