From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/1] ui: qemu: show hint about prerequisites for virgl display
Date: Fri, 29 Apr 2022 18:50:08 +0200 [thread overview]
Message-ID: <20220429165008.734273-3-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20220429165008.734273-1-s.ivanov@proxmox.com>
since there is no hard dependency on the needed libraries (and we
cannot easily check if a fitting GPU is present in the GUI) - notify
the user about the prerequisites - else the error-messages might be a
bit confusing [0]
Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
[0] https://forum.proxmox.com/threads/.61801/post-466750
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
www/manager6/qemu/DisplayEdit.js | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js
index 9bb1763e..602729d6 100644
--- a/www/manager6/qemu/DisplayEdit.js
+++ b/www/manager6/qemu/DisplayEdit.js
@@ -49,6 +49,13 @@ Ext.define('PVE.qemu.DisplayInputPanel', {
memoryfield.setEmptyText(Proxmox.Utils.defaultText);
}
memoryfield.setDisabled(disableMemoryField);
+
+ let hintfield = this.up('panel').down('field[name=virglhint]');
+ if (val === 'virtio-gl') {
+ hintfield.setHidden(false);
+ } else {
+ hintfield.setHidden(true);
+ }
},
},
},
@@ -60,6 +67,14 @@ Ext.define('PVE.qemu.DisplayInputPanel', {
maxValue: 512,
step: 4,
name: 'memory',
+ },
+ {
+ xtype: 'displayfield',
+ userCls: 'pmx-hint',
+ hidden: true,
+ name: 'virglhint',
+ value: gettext('Note: You need to have a physical GPU in the host and have the necessary ' +
+ 'driver and library packages (libgl1, libegl1) installed'),
}],
});
--
2.30.2
prev parent reply other threads:[~2022-04-29 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 16:50 [pve-devel] [PATCH qemu-server/pve-manager] notify users about virtio-gl prerequisites Stoiko Ivanov
2022-04-29 16:50 ` [pve-devel] [PATCH qemu-server 1/1] check prerequisites for virtio-gl display Stoiko Ivanov
2022-05-02 15:25 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-29 16:50 ` Stoiko Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429165008.734273-3-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox