From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: dc/SyncWindow: realign to sync options
Date: Fri, 29 Apr 2022 12:23:36 +0200 [thread overview]
Message-ID: <20220429102336.1988151-1-d.csapak@proxmox.com> (raw)
put the checkboxes in a fieldset and reuse their labels
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/dc/SyncWindow.js | 42 ++++++++++++++++++-----------------
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/www/manager6/dc/SyncWindow.js b/www/manager6/dc/SyncWindow.js
index b32926dd..1d8bef8f 100644
--- a/www/manager6/dc/SyncWindow.js
+++ b/www/manager6/dc/SyncWindow.js
@@ -119,26 +119,28 @@ Ext.define('PVE.dc.SyncWindow', {
columnB: [
{
- xtype: 'displayfield',
- fieldLabel: gettext('Remove Vanished'),
- },
- {
- xtype: 'proxmoxcheckbox',
- fieldLabel: gettext('ACL'),
- name: 'remove-vanished-acl',
- boxLabel: gettext('Remove ACLs of users and groups which are not in the sync response.'),
- },
- {
- xtype: 'proxmoxcheckbox',
- fieldLabel: gettext('Entry'),
- name: 'remove-vanished-entry',
- boxLabel: gettext('Remove users and groups that are not in the sync response.'),
- },
- {
- xtype: 'proxmoxcheckbox',
- fieldLabel: gettext('Properties'),
- name: 'remove-vanished-properties',
- boxLabel: gettext('Remove user-properties that are not in the sync response.'),
+ xtype: 'fieldset',
+ title: gettext('Remove Vanished Options'),
+ items: [
+ {
+ xtype: 'proxmoxcheckbox',
+ fieldLabel: gettext('ACL'),
+ name: 'remove-vanished-acl',
+ boxLabel: gettext('Remove ACLs of vanished users and groups.'),
+ },
+ {
+ xtype: 'proxmoxcheckbox',
+ fieldLabel: gettext('Entry'),
+ name: 'remove-vanished-entry',
+ boxLabel: gettext('Remove vanished user and group entries.'),
+ },
+ {
+ xtype: 'proxmoxcheckbox',
+ fieldLabel: gettext('Properties'),
+ name: 'remove-vanished-properties',
+ boxLabel: gettext('Remove properties from vanished users.'),
+ },
+ ],
},
{
xtype: 'displayfield',
--
2.30.2
next reply other threads:[~2022-04-29 10:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 10:23 Dominik Csapak [this message]
2022-04-29 12:30 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429102336.1988151-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox