From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/2] api: ceph ec pools: schema fixes and enhancements
Date: Fri, 29 Apr 2022 11:28:58 +0200 [thread overview]
Message-ID: <20220429092859.1044258-1-a.lauterer@proxmox.com> (raw)
Ceph has a min value for 'k' of 2. Adding default and description where
missing.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
PVE/API2/Ceph/Pools.pm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Ceph/Pools.pm b/PVE/API2/Ceph/Pools.pm
index eeb81d65..4e28453c 100644
--- a/PVE/API2/Ceph/Pools.pm
+++ b/PVE/API2/Ceph/Pools.pm
@@ -321,7 +321,7 @@ my $ec_format = {
type => 'integer',
description => "Number of data chunks. Will create an erasure coded pool plus a"
." replicated pool for metadata.",
- minimum => 1,
+ minimum => 2,
},
m => {
type => 'integer',
@@ -335,6 +335,7 @@ my $ec_format = {
." coded pool plus a replicated pool for metadata.",
format_description => 'domain',
optional => 1,
+ default => 'host',
},
'device-class' => {
type => 'string',
@@ -386,6 +387,8 @@ __PACKAGE__->register_method ({
optional => 1,
},
'erasure-coding' => {
+ description => "Create an erasure coded pool for RBD with an ".
+ "accompaning replicated pool for metadata storage.",
type => 'string',
format => $ec_format,
optional => 1,
--
2.30.2
next reply other threads:[~2022-04-29 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 9:28 Aaron Lauterer [this message]
2022-04-29 9:28 ` [pve-devel] [PATCH manager 2/2] api: ceph ec pools: make add_storages overridable default Aaron Lauterer
2022-04-29 12:30 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429092859.1044258-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox