From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES v3 qemu-server/manager] more flexible restore
Date: Tue, 26 Apr 2022 14:30:49 +0200 [thread overview]
Message-ID: <20220426123055.110358-1-f.ebner@proxmox.com> (raw)
Allows preserving disks and overriding VM settings upon restore.
For containers, overriding settings was already possible, but managing
partial restore is more involved because of nested mount structure,
etc.
Exposes the functionality in the UI, allowing to set (host)name,
cores(+sockets), memory, and, for VMs, which action should be taken for
the drive.
Also includes the related improvement in the UI, to detect if a
storage needed by the restore is not available.
Changes from v2:
* Dropped already applied patches.
* Switch to a parameter with explicit drive actions, which also
allows setting a per-drive target storage.
* Adapt UI and improve JS style.
Necessary dependency bumps are pve-manager -> widget-toolkit
and pve-manager -> qemu-server -> qemu.
Still missing:
* add documentation for the new restore functionality for VMs and
existing restore functionality for containers.
* add per-drive storage selection to UI (just adding a widgetcolumn
with our storage selector means an API call for each disk, which
is sub-optimal)
qemu-server:
Fabian Ebner (3):
api: create: refactor parameter check logic
api: create: allow overriding non-disk options during restore
restore: allow specifying drive actions during restore
PVE/API2/Qemu.pm | 75 ++++++++++++++++++++++++--------
PVE/QemuServer.pm | 107 ++++++++++++++++++++++++++++++++++++++++++----
2 files changed, 156 insertions(+), 26 deletions(-)
manager:
Fabian Ebner (3):
ui: restore: disallow empty storage selection if it wouldn't work
ui: restore: allow override of some settings
ui: restore: allow treating disks differently
www/manager6/Makefile | 1 +
www/manager6/grid/RestoreDiskGrid.js | 151 +++++++++++++++++++++++++++
www/manager6/window/Restore.js | 130 ++++++++++++++++++++++-
3 files changed, 280 insertions(+), 2 deletions(-)
create mode 100644 www/manager6/grid/RestoreDiskGrid.js
--
2.30.2
next reply other threads:[~2022-04-26 12:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 12:30 Fabian Ebner [this message]
2022-04-26 12:30 ` [pve-devel] [PATCH v3 qemu-server 1/3] api: create: refactor parameter check logic Fabian Ebner
2022-04-28 9:12 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-26 12:30 ` [pve-devel] [PATCH v3 qemu-server 2/3] api: create: allow overriding non-disk options during restore Fabian Ebner
2022-04-28 9:12 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-26 12:30 ` [pve-devel] [PATCH v3 qemu-server 3/3] restore: allow specifying drive actions " Fabian Ebner
2022-04-26 12:30 ` [pve-devel] [PATCH v3 manager 1/3] ui: restore: disallow empty storage selection if it wouldn't work Fabian Ebner
2022-04-28 9:13 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-26 12:30 ` [pve-devel] [PATCH v3 manager 2/3] ui: restore: allow override of some settings Fabian Ebner
2022-04-28 9:13 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-26 12:30 ` [pve-devel] [PATCH v3 manager 3/3] ui: restore: allow treating disks differently Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220426123055.110358-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox