* [pve-devel] [PATCH manager] ui: dont show '__default__' in renderer
@ 2022-04-26 7:34 Dominik Csapak
2022-04-26 13:31 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2022-04-26 7:34 UTC (permalink / raw)
To: pve-devel
with the recent rework of the render/maps/arrays, we now
show 'Default (__default__)'. Since '__default__' is only an internal
value in the gui, don't expose it by explicitely checking for it
in the other render functions it works already because we either construct
the text differently (console_map) or we check the result from
parsing (vga_driver)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/Utils.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index f13a7dec..4611ff0f 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -599,7 +599,7 @@ Ext.define('PVE.Utils', {
},
render_kvm_language: function(value) {
- if (!value) {
+ if (!value || value === '__default__') {
return Proxmox.Utils.defaultText;
}
let text = PVE.Utils.kvm_keymaps[value];
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* [pve-devel] applied: [PATCH manager] ui: dont show '__default__' in renderer
2022-04-26 7:34 [pve-devel] [PATCH manager] ui: dont show '__default__' in renderer Dominik Csapak
@ 2022-04-26 13:31 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-04-26 13:31 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 26.04.22 09:34, Dominik Csapak wrote:
> with the recent rework of the render/maps/arrays, we now
> show 'Default (__default__)'. Since '__default__' is only an internal
> value in the gui, don't expose it by explicitely checking for it
>
> in the other render functions it works already because we either construct
> the text differently (console_map) or we check the result from
> parsing (vga_driver)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/Utils.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-26 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 7:34 [pve-devel] [PATCH manager] ui: dont show '__default__' in renderer Dominik Csapak
2022-04-26 13:31 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox