public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve-kernel-meta] proxmox-boot: fix #3729 add --graceful to bootctl invocation
@ 2022-04-25 16:33 Stoiko Ivanov
  2022-04-26  6:26 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Stoiko Ivanov @ 2022-04-25 16:33 UTC (permalink / raw)
  To: pve-devel

The version of systemd boot in bullseye, tries writing an efivar which
is not writeable on certain (broken) UEFIs (HP thin clients).

The issue was not present in the version in buster (the variable
simply did not get written) and can be worked around by adding
--graceful to the `bootctl install` command.

see also:
https://github.com/systemd/systemd/issues/13603

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
originally sent as part of a series:
https://lists.proxmox.com/pipermail/pve-devel/2022-March/052054.html
as:
https://lists.proxmox.com/pipermail/pve-devel/2022-March/052052.html

however since the issue is really unrelated to the series, and causes
(more) issues for systems with (certain) broken UEFI systems I'm resending
it isolated of the series (which IIRC is a bit too large to integrate
currently)

 bin/proxmox-boot-tool | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/proxmox-boot-tool b/bin/proxmox-boot-tool
index fb4e320..6c0ae4f 100755
--- a/bin/proxmox-boot-tool
+++ b/bin/proxmox-boot-tool
@@ -153,7 +153,7 @@ init() {
 	if [ -d /sys/firmware/efi ]; then
 		echo "Installing systemd-boot.."
 		mkdir -p "$esp_mp/$PMX_ESP_DIR"
-		bootctl --path "$esp_mp" install
+		bootctl --graceful --path "$esp_mp" install
 
 		echo "Configuring systemd-boot.."
 		echo "timeout 3" > "$esp_mp/$PMX_LOADER_CONF.tmp"
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH pve-kernel-meta] proxmox-boot: fix #3729 add --graceful to bootctl invocation
  2022-04-25 16:33 [pve-devel] [PATCH pve-kernel-meta] proxmox-boot: fix #3729 add --graceful to bootctl invocation Stoiko Ivanov
@ 2022-04-26  6:26 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-04-26  6:26 UTC (permalink / raw)
  To: Proxmox VE development discussion, Stoiko Ivanov

On 25.04.22 18:33, Stoiko Ivanov wrote:
> The version of systemd boot in bullseye, tries writing an efivar which
> is not writeable on certain (broken) UEFIs (HP thin clients).
> 
> The issue was not present in the version in buster (the variable
> simply did not get written) and can be worked around by adding
> --graceful to the `bootctl install` command.
> 
> see also:
> https://github.com/systemd/systemd/issues/13603
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> originally sent as part of a series:
> https://lists.proxmox.com/pipermail/pve-devel/2022-March/052054.html
> as:
> https://lists.proxmox.com/pipermail/pve-devel/2022-March/052052.html
> 
> however since the issue is really unrelated to the series, and causes
> (more) issues for systems with (certain) broken UEFI systems I'm resending
> it isolated of the series (which IIRC is a bit too large to integrate
> currently)

Yeah please send unrelated fixes outside of feature series, way easier to
not overlook them and get them in the repo earlier, as now I need to do an
additional bump just to get this packaged...

And if they're semi-related or, whyever else, send in the series please put
them always up front as first patches to allow picking them up already easily
while the later stuff may get another revision.

> 
>  bin/proxmox-boot-tool | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-26  6:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-25 16:33 [pve-devel] [PATCH pve-kernel-meta] proxmox-boot: fix #3729 add --graceful to bootctl invocation Stoiko Ivanov
2022-04-26  6:26 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal