From: Matthias Heiserer <m.heiserer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v1 http-server 2/2] AnyEvent: disable upload timeout
Date: Fri, 22 Apr 2022 16:43:58 +0200 [thread overview]
Message-ID: <20220422144358.3217098-2-m.heiserer@proxmox.com> (raw)
In-Reply-To: <20220422144358.3217098-1-m.heiserer@proxmox.com>
During some testing, I had various requests time out.
Bug reports describing that behaviour include #795 from 2015
and #66 from 2011.
While disabling the timeout is certainly not ideal, it should fix this
issue for now.
Alternatively, a long timout could be set (e.g. 60 seconds).
Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
src/PVE/APIServer/AnyEvent.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm
index ade3c05..c143fb4 100644
--- a/src/PVE/APIServer/AnyEvent.pm
+++ b/src/PVE/APIServer/AnyEvent.pm
@@ -1500,6 +1500,7 @@ sub unshift_read_header {
outfh => $outfh,
};
$reqstate->{tmpfilename} = $tmpfilename;
+ $reqstate->{hdl}->{timeout} = 0;
$reqstate->{hdl}->on_read(sub {
$self->file_upload_multipart($reqstate, $auth, $method, $path, $state);
});
--
2.30.2
next prev parent reply other threads:[~2022-04-22 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 14:43 [pve-devel] [PATCH v1 http-server 1/2] AnyEvent: fix #3990 - rewrite file upload Matthias Heiserer
2022-04-22 14:43 ` Matthias Heiserer [this message]
2022-04-22 16:54 ` [pve-devel] [PATCH v1 http-server 2/2] AnyEvent: disable upload timeout Thomas Lamprecht
2022-05-06 11:44 ` Matthias Heiserer
2022-04-22 16:54 ` [pve-devel] [PATCH v1 http-server 1/2] AnyEvent: fix #3990 - rewrite file upload Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422144358.3217098-2-m.heiserer@proxmox.com \
--to=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox