public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES v10 manager] Add GUI to import disk & VM
Date: Wed,  6 Apr 2022 10:03:57 +0200	[thread overview]
Message-ID: <20220406080416.66227-1-f.ebner@proxmox.com> (raw)

Allows selecting the import source when creating/adding a new VM disk
and makes loading configuration from an OVF manifest in the VM
creation wizard possible.

First patch is also included in the series for the backend.

Patches 2-6 are for making import source selectable when
creating/adding a VM disk.

The rest of the series is preparation for the import functionality
in the various components used by the wizard, with the final patch
adding the functionality itself.


Changes from Dominic's v9:
    * Split out preparatory work, and re-use existing classes, rather
      than re-writing HD edit and multi disk edit functionality as
      separate classes (the latter did not even exist yet when Dominic
      wrote his patch).
    * Show message upon successfull readovf API call.
    * Show import from path/OVF only for root user.
    * Simplify a few things.


Dependency bump for qemu-server is needed.


Dominic Jäger (1):
  ui: qemu: wizard: add import from OVF functionality

Fabian Ebner (18):
  api: nodes: add readovf endpoint
  ui: HD edit: get rid of unneeded binding for backup checkbox
  ui: HD edit: move advanced options into a dedicated tab
  ui: disk storage selector: add setSize function
  ui: file selector: add getCurrentSize function
  ui: HD edit: allow selecting import source
  ui: CD edit: handle change even if not yet rendered
  ui: multi disk edit: only pass confid for addPanel
  ui: HD edit: allow preselecting config ID
  ui: multi HD edit: pre select passed-in config ID
  ui: multi disk edit: allow setting config ID when adding disk
  ui: multi disk edit: add removeAllDisks function
  ui: multi disk edit: allow adding a disk with existing settings
  ui: multi disk edit: expose addDisk outside of the controller
  ui: HD edit: set drive: make specifying file/volid optional
  ui: HD edit: support setting an import path in setDrive
  ui: qemu: memory edit: expose setMemory outside the controller
  ui: qemu: memory edit: allow passing explicit value

 PVE/API2/Nodes.pm                        |   7 +
 www/manager6/form/ControllerSelector.js  |   4 +
 www/manager6/form/DiskStorageSelector.js |  25 +++-
 www/manager6/form/FileSelector.js        |   6 +
 www/manager6/lxc/MultiMPEdit.js          |   9 +-
 www/manager6/panel/MultiDiskEdit.js      |  41 ++++-
 www/manager6/qemu/CDEdit.js              |   3 -
 www/manager6/qemu/CreateWizard.js        |  61 ++++++++
 www/manager6/qemu/HDEdit.js              | 183 +++++++++++++++++++----
 www/manager6/qemu/MemoryEdit.js          |  33 ++--
 www/manager6/qemu/MultiHDEdit.js         |  12 +-
 11 files changed, 324 insertions(+), 60 deletions(-)

-- 
2.30.2





             reply	other threads:[~2022-04-06  8:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06  8:03 Fabian Ebner [this message]
2022-04-06  8:03 ` [pve-devel] [PATCH v10 manager 01/19] api: nodes: add readovf endpoint Fabian Ebner
2022-04-06  8:03 ` [pve-devel] [PATCH v10 manager 02/19] ui: HD edit: get rid of unneeded binding for backup checkbox Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 03/19] ui: HD edit: move advanced options into a dedicated tab Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 04/19] ui: disk storage selector: add setSize function Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 05/19] ui: file selector: add getCurrentSize function Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 06/19] ui: HD edit: allow selecting import source Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 07/19] ui: CD edit: handle change even if not yet rendered Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 08/19] ui: multi disk edit: only pass confid for addPanel Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 09/19] ui: HD edit: allow preselecting config ID Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 10/19] ui: multi HD edit: pre select passed-in " Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 11/19] ui: multi disk edit: allow setting config ID when adding disk Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 12/19] ui: multi disk edit: add removeAllDisks function Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 13/19] ui: multi disk edit: allow adding a disk with existing settings Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 14/19] ui: multi disk edit: expose addDisk outside of the controller Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 15/19] ui: HD edit: set drive: make specifying file/volid optional Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 16/19] ui: HD edit: support setting an import path in setDrive Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 17/19] ui: qemu: memory edit: expose setMemory outside the controller Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 18/19] ui: qemu: memory edit: allow passing explicit value Fabian Ebner
2022-04-06  8:04 ` [pve-devel] [PATCH v10 manager 19/19] ui: qemu: wizard: add import from OVF functionality Fabian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220406080416.66227-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal