From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/2] ui: osd: remove NA from wal device column
Date: Mon, 28 Mar 2022 13:10:41 +0200 [thread overview]
Message-ID: <20220328111041.1732567-2-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20220328111041.1732567-1-a.lauterer@proxmox.com>
It adds visual noise and reduces readability.
This brings the WAL device column in alignment with the DB device column
which is showing whitespace if there is none configured.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
www/manager6/ceph/OSD.js | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
index 78f226ff..adc35464 100644
--- a/www/manager6/ceph/OSD.js
+++ b/www/manager6/ceph/OSD.js
@@ -516,15 +516,6 @@ Ext.define('PVE.node.CephOsdTree', {
return text;
},
- render_wal: function(value, metaData, rec) {
- if (!value &&
- rec.data.osdtype === 'bluestore' &&
- rec.data.type === 'osd') {
- return 'N/A';
- }
- return value;
- },
-
render_version: function(value, metadata, rec) {
let vm = this.getViewModel();
let versions = vm.get('versions');
@@ -638,7 +629,6 @@ Ext.define('PVE.node.CephOsdTree', {
text: "WAL Device",
dataIndex: 'waldev',
align: 'right',
- renderer: 'render_wal',
width: 75,
hidden: true,
},
--
2.30.2
next prev parent reply other threads:[~2022-03-28 11:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 11:10 [pve-devel] [PATCH manager 1/2] api: osd: return block devices instead of dm node Aaron Lauterer
2022-03-28 11:10 ` Aaron Lauterer [this message]
2022-03-29 16:05 ` Thomas Lamprecht
2022-03-30 8:19 ` Aaron Lauterer
2022-03-30 9:46 ` Thomas Lamprecht
2022-03-29 16:08 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328111041.1732567-2-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox