From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/2] api: osd: return block devices instead of dm node
Date: Mon, 28 Mar 2022 13:10:40 +0200 [thread overview]
Message-ID: <20220328111041.1732567-1-a.lauterer@proxmox.com> (raw)
Returning the block devices is more useful than the device node. The
device node usually points to the DM device for bluestore OSDs:
/dev/dm-x
In almost all situations one will be interested in the physical device
underneath, /dev/sdX or /dev/nvmeXnY. In the rare case that someone
isn't, then one can get a lot of more information by running
`ceph osd metadata <osd nr>`.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
PVE/API2/Ceph/OSD.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm
index 93433b3a..c3d1384e 100644
--- a/PVE/API2/Ceph/OSD.pm
+++ b/PVE/API2/Ceph/OSD.pm
@@ -143,9 +143,9 @@ __PACKAGE__->register_method ({
if ($e->{type} eq 'osd' && $osdmd) {
if ($osdmd->{bluefs}) {
$new->{osdtype} = 'bluestore';
- $new->{blfsdev} = $osdmd->{bluestore_bdev_dev_node};
- $new->{dbdev} = $osdmd->{bluefs_db_dev_node};
- $new->{waldev} = $osdmd->{bluefs_wal_dev_node};
+ $new->{blfsdev} = $osdmd->{bluestore_bdev_devices};
+ $new->{dbdev} = $osdmd->{bluefs_db_devices};
+ $new->{waldev} = $osdmd->{bluefs_wal_devices};
} else {
$new->{osdtype} = 'filestore';
}
--
2.30.2
next reply other threads:[~2022-03-28 11:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 11:10 Aaron Lauterer [this message]
2022-03-28 11:10 ` [pve-devel] [PATCH manager 2/2] ui: osd: remove NA from wal device column Aaron Lauterer
2022-03-29 16:05 ` [pve-devel] [PATCH manager 1/2] api: osd: return block devices instead of dm node Thomas Lamprecht
2022-03-30 8:19 ` Aaron Lauterer
2022-03-30 9:46 ` Thomas Lamprecht
2022-03-29 16:08 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220328111041.1732567-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox