public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH access-control/manager/docs v3] fix #3668: improving realm sync
Date: Thu, 24 Mar 2022 13:45:21 +0100	[thread overview]
Message-ID: <20220324124524.3633145-1-d.csapak@proxmox.com> (raw)

this deprecates the 'full' and 'purge' sync options and replaces them with
a 'remove-vanished' option, where we have multiple flags to determine
which things we want to remove when they are not in the sync response.

changes from v2:
* instead of having a mode, define what we actually do: configure what
  we remove when it (or the depending entry) vanishes
* let the user remove the ACLs only, even when not removing the users
* have less fields that the user *must* give on sync, since there are
  more defaults that are explained in the gui

changes from v1:
* replace the 'remove-vanished' by a new 'mode' selection and adding
  an appropriate mode

pve-access-control:

Dominik Csapak (1):
  fix #3668: realm-sync: replace 'full' and 'purge' options with
    'remove-vanished'

 src/PVE/API2/Domains.pm | 162 ++++++++++++++++++++++++++--------------
 src/PVE/Auth/Plugin.pm  |  27 +++++--
 2 files changed, 126 insertions(+), 63 deletions(-)

pve-manager:

Dominik Csapak (1):
  ui: realm sync: replace 'full' and 'purge' with 'remove-vanished'

 www/manager6/dc/AuthEditLDAP.js | 63 +++++++++++++++++++------------
 www/manager6/dc/SyncWindow.js   | 66 ++++++++++++++++++++-------------
 2 files changed, 80 insertions(+), 49 deletions(-)

pve-docs:

Dominik Csapak (1):
  update documentation about sync-options

 pveum.adoc | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

-- 
2.30.2





             reply	other threads:[~2022-03-24 12:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-24 12:45 Dominik Csapak [this message]
2022-03-24 12:45 ` [pve-devel] [PATCH access-control v3 1/1] fix #3668: realm-sync: replace 'full' and 'purge' options with 'remove-vanished' Dominik Csapak
2022-03-24 12:45 ` [pve-devel] [PATCH manager v3 1/1] ui: realm sync: replace 'full' and 'purge' " Dominik Csapak
2022-03-24 12:45 ` [pve-devel] [PATCH docs v3 1/1] update documentation about sync-options Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220324124524.3633145-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal