From: Matthias Heiserer <m.heiserer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 0/5 v2] BackupView as TreePanel
Date: Fri, 18 Mar 2022 14:52:21 +0100 [thread overview]
Message-ID: <20220318135226.2360890-1-m.heiserer@proxmox.com> (raw)
This replaces the backupview for storages and the BackupView for
qemu and lxc with a single TreeView.
Less code, no need to maintain two different BackupView files,
and reduces complexity of ContentView.
Changes from v1:
- replace grid/BackupView with storage/BackupView
- some bug fixes and code cleanup
- group unknown/renamed backups in the folder "Other"
- remember expanded nodes and selection
Matthias Heiserer (5):
Storage GUI: Rewrite backup content view as TreePanel.
GUI: Utils: Helpers for backup type and icon
Backup GUI: Use the new storage/BackupView instead of grid/BackupView.
Remove grid/backupview as it got replaced by storage/backupview
Storage ContentView: remove code that was required only for backupview
www/manager6/Utils.js | 20 +
www/manager6/grid/BackupView.js | 388 ---------------
www/manager6/lxc/Config.js | 2 +-
www/manager6/qemu/Config.js | 2 +-
www/manager6/storage/BackupView.js | 702 ++++++++++++++++++++--------
www/manager6/storage/ContentView.js | 22 +-
6 files changed, 535 insertions(+), 601 deletions(-)
delete mode 100644 www/manager6/grid/BackupView.js
--
2.30.2
next reply other threads:[~2022-03-18 13:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 13:52 Matthias Heiserer [this message]
2022-03-18 13:52 ` [pve-devel] [PATCH manager 1/5 v2] Storage GUI: Rewrite backup content view " Matthias Heiserer
2022-03-22 8:42 ` Fabian Ebner
2022-03-22 12:38 ` Thomas Lamprecht
2022-03-30 12:59 ` Matthias Heiserer
2022-03-31 6:36 ` Fabian Ebner
2022-03-31 6:56 ` Thomas Lamprecht
2022-03-18 13:52 ` [pve-devel] [PATCH manager 2/5 v2] GUI: Utils: Helpers for backup type and icon Matthias Heiserer
2022-03-18 14:51 ` Thomas Lamprecht
2022-03-18 13:52 ` [pve-devel] [PATCH manager 3/5 v2] Backup GUI: Use the new storage/BackupView instead of grid/BackupView Matthias Heiserer
2022-03-22 8:47 ` Fabian Ebner
2022-03-18 13:52 ` [pve-devel] [PATCH manager 4/5 v2] Remove grid/backupview as it got replaced by storage/backupview Matthias Heiserer
2022-03-22 8:47 ` Fabian Ebner
2022-03-18 13:52 ` [pve-devel] [PATCH manager 5/5 v2] Storage ContentView: Remove dead code Matthias Heiserer
2022-03-22 8:48 ` Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318135226.2360890-1-m.heiserer@proxmox.com \
--to=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox