From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit] Utils: clear cookies with secure flag set
Date: Fri, 18 Mar 2022 11:00:11 +0100 [thread overview]
Message-ID: <20220318100011.886719-1-d.csapak@proxmox.com> (raw)
otherwise firefox complains with a deprecation warning that the secureflag
is not set but SameSite to 'None'. Since we cannot know how firefox will
behave once that behaviour is no longer supported, add the secure flag
now.
we have to use the 'set' api of ExtJs to do that reliably
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/Utils.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Utils.js b/src/Utils.js
index 6781e44..52cc626 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -306,7 +306,7 @@ utilities: {
if (Proxmox.LoggedOut) {
return;
}
- Ext.util.Cookies.clear(Proxmox.Setup.auth_cookie_name);
+ Ext.util.Cookies.set(Proxmox.Setup.auth_cookie_name, "", new Date(0), null, null, true);
window.localStorage.removeItem("ProxmoxUser");
},
--
2.30.2
next reply other threads:[~2022-03-18 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 10:00 Dominik Csapak [this message]
2022-03-18 15:29 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318100011.886719-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox