From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager+common 0/2] drop custom node config parser
Date: Thu, 17 Mar 2022 11:26:00 +0100 [thread overview]
Message-ID: <20220317102603.49426-1-w.bumiller@proxmox.com> (raw)
This extends PVE::JSONSchema::parse_config to have an optional "comment
key" to collect comments into and drops the node config parser and its
custom check_type helper to instead use the common parser.
And while I'm at it, I also add the return schema for get_config, since
I see no obvious reason not to.
We do have the 'property' parameter to filter out a specific config
property, but given that the fields are all optional anyway the schema
still matches regardless.
next reply other threads:[~2022-03-17 10:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 10:26 Wolfgang Bumiller [this message]
2022-03-17 10:26 ` [pve-devel] [PATCH manager 1/2] nodeconfig: use common " Wolfgang Bumiller
2022-03-17 13:27 ` [pve-devel] applied: " Thomas Lamprecht
2022-03-17 10:26 ` [pve-devel] [PATCH manager 2/2] api: fill in nodeconfig schema Wolfgang Bumiller
2022-03-17 13:28 ` [pve-devel] applied: " Thomas Lamprecht
2022-03-17 10:26 ` [pve-devel] [PATCH common] schema: parse_config: optionally collect comments Wolfgang Bumiller
2022-03-17 11:27 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220317102603.49426-1-w.bumiller@proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox