* [pve-devel] [PATCH v3 common] REST environment: 'root@pam' fallback in task logs if no user specified for forked worker
@ 2022-03-15 11:52 Oguz Bektas
2022-03-16 6:59 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Oguz Bektas @ 2022-03-15 11:52 UTC (permalink / raw)
To: pve-devel
call sites without a defined user parameter (found only push_file and
pull_file from pve-container) were logging the user as 'root@pve' which
doesn't exist.
for clarity, also add a comment that this is only used for the task
logs.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
v2->v3:
* drop warning message
* pass $noerr to get_user() to avoid dead code in case it fails
src/PVE/RESTEnvironment.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm
index 1b2af08..abe388b 100644
--- a/src/PVE/RESTEnvironment.pm
+++ b/src/PVE/RESTEnvironment.pm
@@ -492,7 +492,8 @@ sub fork_worker {
$dtype = 'unknown' if !defined ($dtype);
$id = '' if !defined ($id);
- $user = 'root@pve' if !defined ($user);
+ # note: below is only used for the task log entry
+ $user = $self->get_user(1) // 'root@pam' if !defined($user);
my $sync = ($self->{type} eq 'cli' && !$background) ? 1 : 0;
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH v3 common] REST environment: 'root@pam' fallback in task logs if no user specified for forked worker
2022-03-15 11:52 [pve-devel] [PATCH v3 common] REST environment: 'root@pam' fallback in task logs if no user specified for forked worker Oguz Bektas
@ 2022-03-16 6:59 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-03-16 6:59 UTC (permalink / raw)
To: Proxmox VE development discussion, Oguz Bektas
On 15.03.22 12:52, Oguz Bektas wrote:
> call sites without a defined user parameter (found only push_file and
> pull_file from pve-container) were logging the user as 'root@pve' which
> doesn't exist.
>
> for clarity, also add a comment that this is only used for the task
> logs.
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> v2->v3:
> * drop warning message
> * pass $noerr to get_user() to avoid dead code in case it fails
>
> src/PVE/RESTEnvironment.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, with slight adaptions to the commit message, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-16 6:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-15 11:52 [pve-devel] [PATCH v3 common] REST environment: 'root@pam' fallback in task logs if no user specified for forked worker Oguz Bektas
2022-03-16 6:59 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox