From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v4 manager 0/6] ui: lxc/qemu: add reassign for disks and volumes
Date: Mon, 14 Mar 2022 10:35:03 +0100 [thread overview]
Message-ID: <20220314093509.349554-1-a.lauterer@proxmox.com> (raw)
This series adds the UI to reassign a disk / volume from one guest to another.
To avoid button clutter, the Move, Reassing and Resize buttons are moved
into a new submenu called "Disk/Volume Action".
Patch 3 to 6 are optional. Patch 3 changes the labels for Move, Reassign
and Resize to remove Volume & Disk as we already have this in the
context of the submenu.
Patch 4 only changes a double negated option.
Patch 5 happend in the process of working on an interface for the
reassign functionality. Since the work of modernizing this componend is
done, why not use it
Patch 6 changes how we store the max number of MPs possible because I
ran into the issue, that I cannot easily match against the object key if
it is 'mps' instead of 'mp'.
v4:
* add PVE.Util.nextFreeMP helper
* filter templates in the reassign target guest list
* code cleanup on multiple locations
* fix padding
v3:
* change to Edit window, removing quite some boilerplate code
* create new submenu for disk/volume actions
* incorporate smaller style nits
* simplify other labels as well, removing 'Volume' and 'Disk' as the
context gives that away already
v2: incorporated feedback I got off list, mainly
* using more modern approaches
* more arrow functions
* reducing use of predefined cbind values and using inline functions
when possible
Aaron Lauterer (6):
ui: utils: add nextFreeMP
ui: lxc/qemu: add disk reassign and action submenu
ui: lxc/qemu: disk/volume action simplify menu items
ui: BusTypeSelector: change noVirtIO to withVirtIO
ui: hdmove: modernize/refactor
ui: util: refactor mps to mp
www/manager6/Makefile | 1 +
www/manager6/Utils.js | 19 +-
www/manager6/form/BusTypeSelector.js | 4 +-
www/manager6/form/ControllerSelector.js | 4 +-
www/manager6/lxc/MPEdit.js | 2 +-
www/manager6/lxc/MultiMPEdit.js | 4 +-
www/manager6/lxc/Resources.js | 66 ++++--
www/manager6/qemu/CDEdit.js | 2 +-
www/manager6/qemu/CIDriveEdit.js | 2 +-
www/manager6/qemu/HDMove.js | 185 +++++++---------
www/manager6/qemu/HDReassign.js | 272 ++++++++++++++++++++++++
www/manager6/qemu/HardwareView.js | 69 ++++--
12 files changed, 490 insertions(+), 140 deletions(-)
create mode 100644 www/manager6/qemu/HDReassign.js
--
2.30.2
next reply other threads:[~2022-03-14 9:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 9:35 Aaron Lauterer [this message]
2022-03-14 9:35 ` [pve-devel] [PATCH v4 manager 1/6] ui: utils: add nextFreeMP Aaron Lauterer
2022-03-14 9:35 ` [pve-devel] [PATCH v4 manager 2/6] ui: lxc/qemu: add disk reassign and action submenu Aaron Lauterer
2022-03-22 11:18 ` Fabian Ebner
2022-03-24 10:46 ` Aaron Lauterer
2022-03-14 9:35 ` [pve-devel] [PATCH v4 manager 3/6] ui: lxc/qemu: disk/volume action simplify menu items Aaron Lauterer
2022-03-24 11:08 ` Thomas Lamprecht
2022-03-14 9:35 ` [pve-devel] [PATCH v4 manager 4/6] ui: BusTypeSelector: change noVirtIO to withVirtIO Aaron Lauterer
2022-03-14 9:35 ` [pve-devel] [PATCH v4 manager 5/6] ui: hdmove: modernize/refactor Aaron Lauterer
2022-03-14 9:35 ` [pve-devel] [PATCH v4 manager 6/6] ui: util: refactor mps to mp Aaron Lauterer
2022-03-22 11:18 ` Fabian Ebner
2022-03-24 10:44 ` Aaron Lauterer
2022-03-22 11:18 ` [pve-devel] [PATCH v4 manager 0/6] ui: lxc/qemu: add reassign for disks and volumes Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220314093509.349554-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox