From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: Utils: remove unnecessary render_kvm_vga_driver
Date: Wed, 9 Mar 2022 15:09:14 +0100 [thread overview]
Message-ID: <20220309140914.994552-1-d.csapak@proxmox.com> (raw)
the 'value' here is already the rendered text, passing it through
render again does not make sense
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/Utils.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index aafe359a..d6aeaf31 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -653,9 +653,9 @@ Ext.define('PVE.Utils', {
},
kvm_vga_driver_array: function() {
- var data = [['__default__', PVE.Utils.render_kvm_vga_driver('')]];
+ var data = [['__default__', Proxmox.Utils.defaultText]];
Ext.Object.each(PVE.Utils.kvm_vga_drivers, function(key, value) {
- data.push([key, PVE.Utils.render_kvm_vga_driver(value)]);
+ data.push([key, value]);
});
return data;
--
2.30.2
next reply other threads:[~2022-03-09 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 14:09 Dominik Csapak [this message]
2022-04-26 7:10 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220309140914.994552-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox