public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH V2 qemu-server 1/2] enable balloon free-page-reporting
Date: Sun,  6 Mar 2022 13:46:46 +0100	[thread overview]
Message-ID: <20220306124647.2267293-2-aderumier@odiso.com> (raw)
In-Reply-To: <20220306124647.2267293-1-aderumier@odiso.com>

Allow balloon device  driver to report hints of guest free pages to the host,
for auto memory reclaim

https://lwn.net/Articles/759413/
https://events19.linuxfoundation.org/wp-content/uploads/2017/12/KVMForum2018.pdf
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
 PVE/QemuServer.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 42f0fbd..a9e86b3 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3846,7 +3846,9 @@ sub config_to_command {
     # enable balloon by default, unless explicitly disabled
     if (!defined($conf->{balloon}) || $conf->{balloon}) {
 	my $pciaddr = print_pci_addr("balloon0", $bridges, $arch, $machine_type);
-	push @$devices, '-device', "virtio-balloon-pci,id=balloon0$pciaddr";
+	my $ballooncmd = "virtio-balloon-pci,id=balloon0$pciaddr";
+	$ballooncmd .= ",free-page-reporting=on" if min_version($machine_version, 6, 2);
+	push @$devices, '-device', $ballooncmd;
     }
 
     if ($conf->{watchdog}) {
-- 
2.30.2




  reply	other threads:[~2022-03-06 12:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-06 12:46 [pve-devel] [PATCH V2 qemu-server 0/2] " Alexandre Derumier
2022-03-06 12:46 ` Alexandre Derumier [this message]
2022-03-16 17:48   ` [pve-devel] [PATCH V2 qemu-server 1/2] " Thomas Lamprecht
2022-03-16 19:32     ` DERUMIER, Alexandre
2022-03-17  8:35       ` Thomas Lamprecht
2022-03-28 10:06       ` DERUMIER, Alexandre
2022-03-06 12:46 ` [pve-devel] [PATCH V2 qemu-server 2/2] add test for virtio-balloon free-page-reporting=on. (qemu 6.2) Alexandre Derumier
2022-04-27  9:23 ` [pve-devel] applied: [PATCH V2 qemu-server 0/2] enable balloon free-page-reporting Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220306124647.2267293-2-aderumier@odiso.com \
    --to=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal