[pve-devel] [PATCH qemu-server] qmp client: increase timeout for thaw

[pve-devel] [PATCH qemu-server] qmp client: increase timeout for thaw

[Fabian Ebner]

Using a loop of freeze, sleep 5, thaw, sleep 5, an idling Windows 11
VM with 4 cores and 8GiB RAM once took 54 seconds for thawing. It took
less than a second about 90% of the time and maximum of a few seconds
for the majortiy of other cases, but there can be outliers where 10
seconds is not enough.

And there can be hookscripts executed upon thaw, which might also not
complete instantly.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 PVE/QMPClient.pm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/PVE/QMPClient.pm b/PVE/QMPClient.pm
index ea4dc0b..8af28e8 100644
--- a/PVE/QMPClient.pm
+++ b/PVE/QMPClient.pm
@@ -113,9 +113,10 @@ sub cmd {
 	    # locked state with high probability, so use an generous timeout
 	    $timeout = 60*60; # 1 hour
 	} elsif ($cmd->{execute} eq 'guest-fsfreeze-thaw') {
-	    # thaw has no possible long blocking actions, either it returns
-	    # instantly or never (dead locked)
-	    $timeout = 10;
+	    # While it should return instantly or never (dead locked) for Linux guests,
+	    # the variance for Windows guests can be big. And there might be hook scripts
+	    # that are executed upon thaw, so use 3 minutes to be on the safe side.
+	    $timeout = 3 * 60;
 	} elsif ($cmd->{execute} eq 'savevm-start' ||
 		 $cmd->{execute} eq 'savevm-end' ||
 		 $cmd->{execute} eq 'query-backup' ||
-- 
2.30.2

[pve-devel] applied: Re: [PATCH qemu-server] qmp client: increase timeout for thaw

[Thomas Lamprecht]

On 02/03/2022 14:21, Fabian Ebner wrote:
> Using a loop of freeze, sleep 5, thaw, sleep 5, an idling Windows 11
> VM with 4 cores and 8GiB RAM once took 54 seconds for thawing. It took
> less than a second about 90% of the time and maximum of a few seconds
> for the majortiy of other cases, but there can be outliers where 10
> seconds is not enough.
> 
> And there can be hookscripts executed upon thaw, which might also not
> complete instantly.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  PVE/QMPClient.pm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
>

applied, thanks!