public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Matthias Heiserer <m.heiserer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] storage GUI: fix unintuitive sorting order
Date: Fri, 18 Feb 2022 11:42:30 +0100	[thread overview]
Message-ID: <20220218104230.311652-1-m.heiserer@proxmox.com> (raw)

The backups in the 'Backups' table in Storages are now initially
sorted by column 'Name' ascending.

Previously, they were first sorted by 'vmid' descending, then by date
descending. This was unintuitive as 'vmid' doesn't exist as column
in the GUI, and only 'Date' displayed a sorting arrow.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 www/manager6/storage/BackupView.js | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/www/manager6/storage/BackupView.js b/www/manager6/storage/BackupView.js
index 2328c0fc..f02944c9 100644
--- a/www/manager6/storage/BackupView.js
+++ b/www/manager6/storage/BackupView.js
@@ -211,13 +211,9 @@ Ext.define('PVE.storage.BackupView', {
 	me.store.getSorters().clear();
 	me.store.setSorters([
 	    {
-		property: 'vmid',
+		property: 'text',
 		direction: 'ASC',
 	    },
-	    {
-		property: 'vdate',
-		direction: 'DESC',
-	    },
 	]);
     },
 });
-- 
2.30.2





             reply	other threads:[~2022-02-18 10:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18 10:42 Matthias Heiserer [this message]
2022-02-21  8:32 ` Fabian Ebner
2022-02-21  8:39   ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220218104230.311652-1-m.heiserer@proxmox.com \
    --to=m.heiserer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal