From: Mira Limbeck <m.limbeck@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 storage 1/2] fix #3894: cast 'size' and 'used' to integer
Date: Fri, 18 Feb 2022 09:58:26 +0100 [thread overview]
Message-ID: <20220218085827.52533-1-m.limbeck@proxmox.com> (raw)
Perl's automatic conversion can lead to integers being converted to
strings, for example by matching it in a regex.
To make sure we always return an integer in the API call, add an
explicit cast to integer.
Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
---
v3:
- fixed style nits
- added R-b tag
v2:
- new
PVE/API2/Storage/Content.pm | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm
index 45b8de8..8ff858d 100644
--- a/PVE/API2/Storage/Content.pm
+++ b/PVE/API2/Storage/Content.pm
@@ -139,7 +139,9 @@ __PACKAGE__->register_method ({
foreach my $item (@$vollist) {
eval { PVE::Storage::check_volume_access($rpcenv, $authuser, $cfg, undef, $item->{volid}); };
next if $@;
- $item->{vmid} = int($item->{vmid}) if (defined($item->{vmid}));
+ $item->{vmid} = int($item->{vmid}) if defined($item->{vmid});
+ $item->{size} = int($item->{size}) if defined($item->{size});
+ $item->{used} = int($item->{used}) if defined($item->{used});
push @$res, $item;
}
@@ -326,8 +328,8 @@ __PACKAGE__->register_method ({
my $entry = {
path => $path,
- size => $size,
- used => $used,
+ size => int($size), # cast to integer in case it was changed to a string previously
+ used => int($used),
format => $format,
};
--
2.30.2
next reply other threads:[~2022-02-18 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 8:58 Mira Limbeck [this message]
2022-02-18 8:58 ` [pve-devel] [PATCH storage v3 2/2] file_size_info: " Mira Limbeck
2022-02-21 15:08 ` [pve-devel] applied: " Thomas Lamprecht
2022-02-21 15:08 ` [pve-devel] applied: [PATCH v3 storage 1/2] fix #3894: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218085827.52533-1-m.limbeck@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox