[pve-devel] [RFC manager 0/5] GUI: Hardware comments

[Matthias Heiserer <m.heiserer@proxmox.com>]

This series is a first attempt to fix 2672 by implementing editable comments
that are displayed in the GUI and stored in the qemu config file. 

It works, but there are several questions:

How should comments be displayed? (GUI)
    I added a third column. IMO, this looks cleaner than the alternative of
    appending the comment to the corresponding config values. However, it 
    requires more space and some special logic.
    
What to do when there is not enough space? (GUI)
    Currently, this case is not handled. A possible solution would be to
    wrap overflowing lines, but I'm not sure what opinions are on that.
    
Should comments of ineditable fields (EFI Disk) be editable? (GUI)
    I suppose yes, but currently they are not.

Currently missing are:
    GUI: Comments in the wizard, i.e. when creating a VM, no comment can be set.
    Detaching disks voids their comment. Probably shouldn't happen, but seems
        a tad complicated.
    The GUI assumes comments (except memory, socket, bios,  machine, scsihw)
        to be URIencoded. This could be verified server-side.

Generally, I tried to keep the code consistent, but didnt always succeed, partly
because of the variations in the original code.


Matthias Heiserer (5):
  GUI: Parser: add comment support
  GUI: Utils: add comment renderer and field provider
  GUI: QEMU Hardware: add comment column
  GUI: QEMU Hardware: multikey support for comments
  GUI: QEMU Hardware: add comment fields to rows

 www/manager6/Parser.js             | 22 +++++++++++++++
 www/manager6/Utils.js              | 39 +++++++++++++++++++++++++++
 www/manager6/qemu/AudioEdit.js     |  3 ++-
 www/manager6/qemu/CDEdit.js        |  7 ++---
 www/manager6/qemu/CIDriveEdit.js   |  2 ++
 www/manager6/qemu/DisplayEdit.js   |  2 +-
 www/manager6/qemu/HDEdit.js        |  4 +++
 www/manager6/qemu/HDEfi.js         |  3 +++
 www/manager6/qemu/HDTPM.js         |  2 ++
 www/manager6/qemu/HardwareView.js  | 43 +++++++++++++++++++++++++++++-
 www/manager6/qemu/MachineEdit.js   | 24 ++++++++++-------
 www/manager6/qemu/MemoryEdit.js    |  3 +++
 www/manager6/qemu/NetworkEdit.js   |  7 +++--
 www/manager6/qemu/PCIEdit.js       |  1 +
 www/manager6/qemu/ProcessorEdit.js |  1 +
 www/manager6/qemu/QemuBiosEdit.js  |  1 +
 www/manager6/qemu/RNGEdit.js       |  1 +
 www/manager6/qemu/ScsiHwEdit.js    | 15 ++++++-----
 www/manager6/qemu/SerialEdit.js    |  6 ++---
 www/manager6/qemu/USBEdit.js       | 13 ++++++++-
 20 files changed, 171 insertions(+), 28 deletions(-)

-- 
2.30.2